Merge lp:~jkakar/subunit/ppa-build into lp:~subunit/subunit/trunk

[Jamu Kakar]

[Jamu Kakar (jkakar)]

This branch adds a debian/ directory to subunit with Debian
packaging files. It's setup to build the python-subunit package for
multiple versions of Ubuntu with AutoPPA.

Some things that might need improvement:

1. In the end I had to symlink python/subunit to subunit, so that
   setuptools could find the package (this happens in setup.py).
   Maybe there's a better way to do this? I Google'd a bit, but
   didn't find anything like a package_root_path or similar that I
   could pass to the setup function.

2. None of the C or C++ code is used/compiled/installed. I decided
   not to worry about this for now, though thinking about it more it
   probably would be a good idea to install libsubunit.so.

3. I didn't find a version number so I chose 0.0.1 arbitrarily.

I've built python-subunit packages using this code. They are
available in my PPA at:

https://edge.launchpad.net/~jkakar/+archive/ppa

I've installed the hardy package and verified that 'import subunit'
works in a Python interpreter. Anyway, if the packages built by
this branch are acceptable I'd like to rebuild and distribute them
in a subunit-focused PPA.

[Jelmer Vernooij (jelmer)]

Jamu Kakar wrote:
> Jamu Kakar has proposed merging lp:~jkakar/subunit/ppa-build into
> lp:subunit.
>
> Requested reviews: Subunit Developers (subunit)
>
> This branch adds a debian/ directory to subunit with Debian
> packaging files. It's setup to build the python-subunit package
> for multiple versions of Ubuntu with AutoPPA.
>
Thanks for PPA-packaging subunit; I don't think distro-specific
packaging like this belongs in the main branch though - Subunit is not
a native package.

vote reject

Cheers,

Jelmer

[Jelmer Vernooij (jelmer)]

review: Abstain

[Jelmer Vernooij (jelmer)]

review: Disapprove

[Robert Collins (lifeless)]

> This branch adds a debian/ directory to subunit with Debian
> packaging files. It's setup to build the python-subunit package for
> multiple versions of Ubuntu with AutoPPA.
>
> Some things that might need improvement:
>
> 1. In the end I had to symlink python/subunit to subunit, so that
> setuptools could find the package (this happens in setup.py).
> Maybe there's a better way to do this? I Google'd a bit, but
> didn't find anything like a package_root_path or similar that I
> could pass to the setup function.

package_dir = {'':python}

but distutils is heinous for non-python, and subunit is only partially python, which is why it doesn't use a setup.py.
...
> I've installed the hardy package and verified that 'import subunit'
> works in a Python interpreter. Anyway, if the packages built by
> this branch are acceptable I'd like to rebuild and distribute them
> in a subunit-focused PPA.

You're welcome to do that - in fact, if you join the subunit developers team you can use the subunit ppa. I've done somewhat more comprehensive packaging for subunit now though - so this branch is rather stale. We could do with more uploads etc :) I'm sorry that the effort you put in wasn't directly used.

review: Needs Fixing

Unmerged revisions

66. By Jamu Kakar on 2009-03-30

- Fix rules file.

65. By Jamu Kakar on 2009-03-30

- Moved setup.py back to the root directory and updated it to use a
  symlink to point to subunit.

64. By Jamu Kakar on 2009-03-30

- Fix broken path in rules file.

63. By Jamu Kakar on 2009-03-30

- Move setup.py into the python directory so that setuptools can
  find the subunit package.

62. By Jamu Kakar on 2009-03-30

- Added Debian packaging files and a setuptools setup.py file.

=== added directory 'debian'
=== added file 'debian/changelog'
--- debian/changelog	1970-01-01 00:00:00 +0000
+++ debian/changelog	2009-03-30 02:50:56 +0000
@@ -0,0 +1,5 @@
+subunit (0.0.0~trunk) feisty; urgency=low
+
+  * New upstream release.
+
+ -- Jamshed Kakar <[e-mail]>  Sun, 29 Mar 2009 19:47:00 -0700

=== added file 'debian/compat'
--- debian/compat	1970-01-01 00:00:00 +0000
+++ debian/compat	2009-03-30 02:50:56 +0000
@@ -0,0 +1,1 @@
+5

=== added file 'debian/control'
--- debian/control	1970-01-01 00:00:00 +0000
+++ debian/control	2009-03-30 02:50:56 +0000
@@ -0,0 +1,16 @@
+Source: subunit
+Section: universe/devel
+Priority: optional
+Maintainer: Jamshed Kakar <[e-mail]>
+Build-Depends: debhelper, python-central, lsb-release
+Standards-Version: 3.7.2
+XS-Python-Version: current
+
+Package: python-subunit
+Architecture: any
+Depends: ${python:Depends}, ${shlibs:Depends}
+Provides: ${python:Provides}
+XB-Python-Version: ${python:Versions}
+Description: Subunit is attempting to extend unittest with a clean
+ and simple api to run arbitrary external test suites and return the
+ results to standard Python unittest.

=== added file 'debian/control.autoppa'
--- debian/control.autoppa	1970-01-01 00:00:00 +0000
+++ debian/control.autoppa	2009-03-30 02:50:56 +0000
@@ -0,0 +1,17 @@
+Source: subunit
+Section: universe/devel
+Priority: optional
+Maintainer: Jamshed Kakar <[e-mail]>
+AUTOPPA_INCLUDE(dapper):Build-Depends: debhelper, python-support, python2.4-dev, lsb-release
+AUTOPPA_INCLUDE(hardy,intrepid,jaunty):Build-Depends: debhelper, python-central, python-dev, lsb-release
+Standards-Version: 3.7.2
+XS-Python-Version: current
+
+Package: python-subunit
+Architecture: any
+Depends: ${python:Depends}, ${shlibs:Depends}
+Provides: ${python:Provides}
+XB-Python-Version: ${python:Versions}
+Description: Subunit is attempting to extend unittest with a clean
+ and simple api to run arbitrary external test suites and return the
+ results to standard Python unittest.

=== added file 'debian/copyright'
--- debian/copyright	1970-01-01 00:00:00 +0000
+++ debian/copyright	2009-03-30 02:50:56 +0000
@@ -0,0 +1,10 @@
+Copyright:
+
+   Copyright (C) 2005  Robert Collins <[e-mail]>
+
+License:
+
+   GPL
+
+On Ubuntu systems, the complete text of the GNU General Public
+License is in `/usr/share/common-licenses/GPL'.

=== added file 'debian/rules'
--- debian/rules	1970-01-01 00:00:00 +0000
+++ debian/rules	2009-03-30 06:53:18 +0000
@@ -0,0 +1,55 @@
+#!/usr/bin/make -f
+
+dist_release := $(shell lsb_release -cs)
+ifneq ($(dist_release),dapper)
+  use_pycentral = yes
+endif
+
+package = python-subunit
+root_dir = debian/$(package)
+
+build: build-stamp
+build-stamp:
+	dh_testdir
+	python setup.py build
+	touch build-stamp
+
+clean:
+	dh_testdir
+	dh_testroot
+	rm -f build-stamp
+	rm -rf build
+	dh_clean
+
+install: build
+	dh_testdir
+	dh_testroot
+	dh_clean -k
+	python setup.py install --root $(root_dir)
+
+binary-indep: build install
+
+binary-arch: build install
+	dh_testdir
+	dh_testroot
+	dh_installdocs
+	dh_installchangelogs
+	dh_installinit
+	dh_installdebconf
+	dh_installlogrotate
+	dh_compress
+	dh_fixperms
+
+ifeq ($(use_pycentral),yes)
+	DH_PYCENTRAL=nomove dh_pycentral
+else
+	dh_python
+endif
+	dh_installdeb
+	dh_gencontrol
+	dh_md5sums
+	dh_builddeb
+
+binary: binary-indep binary-arch
+
+.PHONY: binary binary-arch binary-indep clean

=== added file 'setup.py'
--- setup.py	1970-01-01 00:00:00 +0000
+++ setup.py	2009-03-30 06:41:16 +0000
@@ -0,0 +1,37 @@
+#!/usr/bin/env python
+import os
+import re
+
+try:
+    from setuptools import setup, Extension
+except ImportError:
+    from distutils.core import setup, Extension
+
+
+if os.path.isfile("MANIFEST"):
+    os.unlink("MANIFEST")
+
+assert not os.path.exists("subunit")
+os.symlink("python/subunit", "subunit")
+try:
+    setup(
+        name="subunit",
+        version="0.0.1",
+        description=("Extensions to Python unittest to get test results "
+                     "from subprocesses."),
+        author="Robert Collins",
+        author_email="[e-mail]",
+        license="GPL",
+        url="https://launchpad.net/subunit",
+        packages=["subunit"],
+        zip_safe=False,
+        classifiers=[
+            "Development Status :: 4 - Beta",
+            "Intended Audience :: Developers",
+            "License :: OSI Approved :: GNU General Public License (GPL)",
+            "Programming Language :: Python",
+            "Topic :: Software Development :: Libraries :: Python Modules",
+        ],
+    )
+finally:
+    os.unlink("subunit")