Code review comment for lp:~jkakar/storm/block-access-context-manager

Revision history for this message
James Henstridge (jamesh) wrote :

Adding the __future__ import seems worth doing.

I'm not sure whether 2.4 compatibility is that important now though. We mainly kept it for support for apps stuck using versions of Zope 3 from before that framework was updated to work with current versions of Python (namely Launchpad). Given that Zope 3 has moved on, it isn't clear whether we need to maintain 2.4 compatibility now.

In contrast, the previous Ubuntu LTS release (Hardy) didn't have 2.6, so it is quite possible that we've still got some boxes that still don't have 2.6 rolled out yet. I assume it'd be similar for some users on other enterprise distros.

It would be nice to require 2.6 at some point though, since it would let us start preparing for Python 3 support, but I'm not convinced we're there yet.

Anyway: with a __future__ import, I've got no objection to this change.

review: Approve

« Back to merge proposal