Code review comment for lp:~jkakar/storm/block-access-context-manager

Revision history for this message
Jamu Kakar (jkakar) wrote :

James:

Yeah, I wondered about that when I implemented the change. I put it
in its own module to keep Storm workable with older versions of
Python. Perhaps we can do two things to make it better:

1. Use a __future__ import to make it usable with Python 2.5.

2. Add a version check in the tests to make sure the test suite
   continues to run on Python 2.4.

What do you think?

« Back to merge proposal