Code review comment for lp:~jkakar/launchpadlib/fake-launchpad

Revision history for this message
Jamu Kakar (jkakar) wrote :

Leonard:

[1]

Agreed. I didn't really realize that was the right place for this
when I started, but it would be great if lazr.restfulclient using
applications had access to something like this out-of-the-box.

Okay, so the index-based lookups are something special layered on
top of the WADL and not something that can be determined directly
from it, right?

[2]

Using a small purpose-built WADL file is a good idea. As for
Jonathan's suggestion to use Python, I think anyone hacking on this
code probably ought to know how WADL works or or at least make
random guesses like I did. That said, maybe a WADL builder would be
useful in other places and could be used here.

Two things would have been very helpful:

1. Having a model-based representation of the model, so that I
   didn't have to deal with XML directly.

2. Documentation describing, in simple terms, how the WADL file
   works. I mostly guessed and, I think, mostly got things right.

[3]

That's a good idea, it is confusing right now.

[4]

I'll have to check this out, thanks for the hint.

[5]

The FakeCollection is only used for parameters that end in
_collection_link. I think you're right though, the logic that wraps
method call return types in FakeResource should be smarter and
determine if the return type is a collection.

Thanks for taking the time to look at this.

« Back to merge proposal