d18986f...
by
Ananth N Mavinakayanahalli <email address hidden>
hw/fsp: Do not queue SP and SPCN class messages during reset/reload
During FSP R/R, the FSP is inaccessible and will lose state. Messages to the
FSP are generally queued for sending later.
It does seem like the FSP fails to process any subseuqent messages of certain
classes (SP info -- ipmi) if it receives queued mbox messages it isn't expecting.
In certain other cases (sensors), the FSP driver returns a default code (async
completion) even though there is no known bound from the time of this error
return to the actual data being available. The kernel driver keeps waiting
leading to soft-lockup on the host side.
Mitigate both these (known) cases by returning OPAL_BUSY so the host driver
knows to retry later.
With this change, the sensors command works fine when the FSP comes back.
This version also resolves the remaining IPMI issues
Signed-off-by: Ananth N Mavinakayanahalli <email address hidden>
Tested-by: Pridhiviraj Paidipeddi <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 4940b8148640c06e139aec8c6d0370af7dd3b184)
Signed-off-by: Stewart Smith <email address hidden>
Limit number of "Poller recursion detected" errors to display
In some error conditions, we could spiral out of control on this
and spend all of our time printing the exact same backtrace.
Limit it to 16 times, because 16 is a nice number.
Cc: stable
Signed-off-by: Stewart Smith <email address hidden>
Reviewed-by: Vasant Hegde <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit b6a729e118f42dae88ebf70a09a7e2aa4f788fdc)
Signed-off-by: Stewart Smith <email address hidden>
If we were to terminate in a poller, we'd call op_display() which
called pollers which hit the recursive poller warning, which ended
in not much fun at all.
This patch will skip the running of pollers and instead run
the FSP poller to set the op-panel display before attn.
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 9fcb109218b1374a8caa3cac62e83fbedb1f7f2f)
Signed-off-by: Stewart Smith <email address hidden>
I made the inappropriate assumption: PCI slot's power state is
always on from the beginning. We don't check the slot's power
state before turning it off in PCI enumeration path when there
are no PCI adapters behind the slot. The PCI slot's power might
have been turned off and we needn't power it off again. Otherwise,
the below (not harmful) message is raised:
This checks power state and avoid turning it off again if it's
already in off state. Flag PCI_SLOT_FLAG_BOOTUP is also removed
after the requested operation is completed as the flag should
be used at skiboot booting stage.
Cc: stable # 5.3.0+
Reported-by: Pridhiviraj Paidipeddi <email address hidden>
Signed-off-by: Gavin Shan <email address hidden>
Tested-by: Pridhiviraj Paidipeddi <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 1408f6f9baa684f280dfb2c4a66daa4d5db996b2)
Signed-off-by: Stewart Smith <email address hidden>
hw/phb3: Override root slot's prepare_link_change() with PHB's
For PCI slot behind root port, its prepare_link_change() should be
same to PHB's. Otherwise, the UTL events cannot be masked when the
slot is reseted, leading to EEH error because of UTL link-down
event.
Cc: stable # 5.3.0+
Signed-off-by: Gavin Shan <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 2e19de4c2f4b47f0259ba265ea7d1786f1b44cd7)
Signed-off-by: Stewart Smith <email address hidden>
When RC's downstream link is down, we need reserve spare PCI buses
if it has an associated PCI hotplug slot. Otherwise, the adapter
behind it can't be probed successfully in PCI hot add scenario.
This reserves all available buses (to 255) for RC's hotplug slot
when its downstream is down so that PCI adapter can be hot added
to the slot afterwards.
Cc: stable # 5.3.0+
Signed-off-by: Gavin Shan <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 481ad7330e332770b1dcd2c9f56d0a2caac67755)
Signed-off-by: Stewart Smith <email address hidden>
We might need know the associated PCI slot before applying the chip
level quirk (phb->ops->device_init()) so that special configuration
on the specific PCI slot can be applied.
This moves the logic of creating PCI slot, applying the quirk and
linking the newly probed device to parent's child list to function
pci_scan_one(). Also, the PCI slot is created prior to applying the
quirk.
Cc: stable # 5.3.0+
Signed-off-by: Gavin Shan <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 39aad95618fea977464bfc38ec0c190075a26304)
Signed-off-by: Stewart Smith <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
d3de60b...
by
Russell Currey <email address hidden>
pci: Avoid hot resets at boot time
In the PCI post-fundamental reset code, a hot reset is performed at the
end. This is causing issues at boot time as a reset signal is being sent
downstream before the links are up, which is causing issues on adapters
behind switches. No errors result in skiboot, but the adapters are not
usable in Linux as a result.
Hot resets also occur in the FSP platform-specific code for conventional
PCI slots, which could cause issues.
This patch fixes some adapters not being configurable in Linux on some
systems. The issue was not present in skiboot 5.2.x.
Cc: stable # 5.3.x
Signed-off-by: Russell Currey <email address hidden>
Acked-by: Gavin Shan <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit 5ac71c9b9f7a6c7dc909bdcf121f8d1d11a10dc2)
Signed-off-by: Stewart Smith <email address hidden>
94ea260...
by
Shilpasri G Bhat <email address hidden>
occ/prd/opal-prd: Queue OCC_RESET event message to host in OpenPOWER
During an OCC reset cycle the system is forced to Psafe pstate.
When OCC becomes active, the system has to be restored to its
last pstate as requested by host. So host needs to be notified
of OCC_RESET event or else system will continue to remian in
Psafe state until host requests a new pstate after the OCC
reset cycle.
This patch defines 'OPAL_PRD_MSG_TYPE_OCC_RESET_NOTIFY' to
notify OPAL when opal-prd issues OCC reset. OPAL will queue
OCC_RESET message to host when it receives opal_prd_msg of
type '*_OCC_RESET_NOTIFY'.
Signed-off-by: Shilpasri G Bhat <email address hidden>
Signed-off-by: Stewart Smith <email address hidden>
(cherry picked from commit b5e54375bdc424eb2e709d41d2306d854f7e07bb)
Signed-off-by: Stewart Smith <email address hidden>
