Merge ~jjo/layer-snap:jjo-add-setup_py into ~stub/layer-snap:master

Proposed by JuanJo Ciarlante
Status: Rejected
Rejected by: Stuart Bishop
Proposed branch: ~jjo/layer-snap:jjo-add-setup_py
Merge into: ~stub/layer-snap:master
Diff against target: 39 lines (+28/-0)
2 files modified
lib/charms/layer/__init__.py (+0/-0)
setup.py (+28/-0)
Reviewer Review Type Date Requested Status
Stuart Bishop Approve
Review via email: mp+318294@code.launchpad.net

Commit message

[jjo] add basic setup.py and charms/layer/__init__.py

To post a comment you must log in.
Revision history for this message
JuanJo Ciarlante (jjo) wrote :

Need to use at e.g. test_requirements.txt:
-e git+https://git.launchpad.net/layer-snap#egg=charms.layer

Revision history for this message
Stuart Bishop (stub) wrote :

Ok. This seems like a hack, but one I can live with at my end.

review: Approve
Revision history for this message
Stuart Bishop (stub) wrote :

I rolled this back. Adding lib/charms/layer/__init__.py breaks the basic layer, which uses that file to provide the charms.layer.options datastructure.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/charms/layer/__init__.py b/lib/charms/layer/__init__.py
2new file mode 100644
3index 0000000..e69de29
4--- /dev/null
5+++ b/lib/charms/layer/__init__.py
6diff --git a/setup.py b/setup.py
7new file mode 100755
8index 0000000..79f7858
9--- /dev/null
10+++ b/setup.py
11@@ -0,0 +1,28 @@
12+#!/usr/bin/env python
13+
14+import os
15+from setuptools import setup
16+
17+here = os.path.abspath(os.path.dirname(__file__))
18+
19+with open(os.path.join(here, 'README.md')) as f:
20+ README = f.read()
21+
22+setup(name='layer_snap',
23+ version='0.0.1',
24+ description='layer_snap',
25+ long_description=README,
26+ license='Apache License 2.0',
27+ classifiers=[
28+ "Development Status :: 4 - Beta",
29+ "Intended Audience :: Developers",
30+ "Programming Language :: Python :: 2",
31+ "Programming Language :: Python :: 2.7",
32+ "Programming Language :: Python :: 3",
33+ ],
34+ url='https://git.launchpad.net/layer-snap',
35+ package_dir={'': 'lib'},
36+ packages=['charms/layer'],
37+ include_package_data=True,
38+ zip_safe=False,
39+ )

Subscribers

People subscribed via source and target branches