Merge lp:~jjo/charms/precise/rsyslog-forwarder/fix-config-changed-and-other-mv-usages into lp:charms/rsyslog-forwarder

Proposed by JuanJo Ciarlante
Status: Merged
Approved by: Robert Ayres
Approved revision: 7
Merged at revision: 7
Proposed branch: lp:~jjo/charms/precise/rsyslog-forwarder/fix-config-changed-and-other-mv-usages
Merge into: lp:charms/rsyslog-forwarder
Diff against target: 43 lines (+4/-4)
4 files modified
hooks/config-changed (+1/-1)
hooks/syslog-relation-departed (+1/-1)
hooks/syslog-relation-joined (+1/-1)
revision (+1/-1)
To merge this branch: bzr merge lp:~jjo/charms/precise/rsyslog-forwarder/fix-config-changed-and-other-mv-usages
Reviewer Review Type Date Requested Status
Robert Ayres (community) Approve
Review via email: mp+144687@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Ayres (robert-ayres) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/config-changed'
2--- hooks/config-changed 2012-10-25 14:56:57 +0000
3+++ hooks/config-changed 2013-01-24 12:12:22 +0000
4@@ -1,6 +1,6 @@
5 #!/bin/bash
6
7-keep_logs=`config-changed log-locally`
8+keep_logs=`config-get log-locally`
9 keep_logs=${keep_logs,,}
10
11 if [ "$keep_logs" == "true" ]; then
12
13=== modified file 'hooks/syslog-relation-departed'
14--- hooks/syslog-relation-departed 2012-04-17 19:39:09 +0000
15+++ hooks/syslog-relation-departed 2013-01-24 12:12:22 +0000
16@@ -6,6 +6,6 @@
17
18 rm -f /etc/rsyslog.d/80-$JUJU_RELATION_ID.conf
19
20-[ ! -f /etc/rsyslog.d/50-default.conf.off ] || mv -f /etc/rsyslog.d/50-default.conf.off /etc/rsyslog.d/50-default.conf
21+[ -f /etc/rsyslog.d/50-default.conf.off ] && mv -f /etc/rsyslog.d/50-default.conf{.off,}
22
23 service rsyslog restart
24
25=== modified file 'hooks/syslog-relation-joined'
26--- hooks/syslog-relation-joined 2012-04-17 19:39:09 +0000
27+++ hooks/syslog-relation-joined 2013-01-24 12:12:22 +0000
28@@ -4,7 +4,7 @@
29
30 rservice=${JUJU_REMOTE_UNIT%%/*}
31
32-mv -f /etc/rsyslog.d/50-default.conf /etc/rsyslog.d/50-default.conf.off
33+[ -f /etc/rsyslog.d/50-default.conf ] && mv -f /etc/rsyslog.d/50-default.conf{,.off}
34
35 sed -e "s/@@server@@/@@`relation-get private-address`/g;
36 s/@@service@@/$rservice/g" \
37
38=== modified file 'revision'
39--- revision 2012-04-17 19:39:09 +0000
40+++ revision 2013-01-24 12:12:22 +0000
41@@ -1,1 +1,1 @@
42-8
43+9

Subscribers

People subscribed via source and target branches

to all changes: