Trivial: 'canditate' should be 'candidate' throughout.
pg_version() makes several assumptions (e.g. that a postgresql package
exists and that it's version matches a specific regex (which won't be
the case if, e.g. the package grows an epoch) that are probably fine,
but it caught my eye.
| + # expensive operation, save it
What operation does this refer to? The function as a whole?
Trivial: 'canditate' should be 'candidate' throughout.
pg_version() makes several assumptions (e.g. that a postgresql package
exists and that it's version matches a specific regex (which won't be
the case if, e.g. the package grows an epoch) that are probably fine,
but it caught my eye.
| + # expensive operation, save it
What operation does this refer to? The function as a whole?