Merge lp:~jjo/charm-helpers/add-wait-timeout into lp:charm-helpers

Proposed by JuanJo Ciarlante
Status: Merged
Merged at revision: 330
Proposed branch: lp:~jjo/charm-helpers/add-wait-timeout
Merge into: lp:charm-helpers
Diff against target: 13 lines (+3/-0)
1 file modified
charmhelpers/contrib/database/mysql.py (+3/-0)
To merge this branch: bzr merge lp:~jjo/charm-helpers/add-wait-timeout
Reviewer Review Type Date Requested Status
Jorge Niedbalski (community) Approve
Review via email: mp+251745@code.launchpad.net

Commit message

[jjo, r=] add wait-timeout config

To post a comment you must log in.
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hello jjo,

I had to add a test for covering your changes, other than that, LGTM.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/database/mysql.py'
2--- charmhelpers/contrib/database/mysql.py 2015-02-27 16:10:02 +0000
3+++ charmhelpers/contrib/database/mysql.py 2015-03-04 14:18:20 +0000
4@@ -357,6 +357,9 @@
5 if 'max-connections' in config:
6 mysql_config['max_connections'] = config['max-connections']
7
8+ if 'wait-timeout' in config:
9+ mysql_config['wait_timeout'] = config['wait-timeout']
10+
11 # Set a sane default key_buffer size
12 mysql_config['key_buffer'] = self.human_to_bytes('32M')
13 total_memory = self.human_to_bytes(self.get_mem_total())

Subscribers

People subscribed via source and target branches