Merge lp:~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests

Proposed by Jack Fromm
Status: Merged
Merged at revision: 206
Proposed branch: lp:~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised
Merge into: lp:ubuntu-manual-tests
Diff against target: 166 lines (+35/-32)
2 files modified
testcases/packages/1557_Mousepad (+27/-24)
testcases/packages/1558_Xfce4 Terminal (+8/-8)
To merge this branch: bzr merge lp:~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised
Reviewer Review Type Date Requested Status
Elfy (community) Approve
Jackson Doak (community) Approve
Review via email: mp+178856@code.launchpad.net

This proposal supersedes a proposal from 2013-08-05.

Description of the change

Change "open" instructions in Mousepad test to make them flavor-agnostic.

To post a comment you must log in.
Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

Can you make the test flavour agnostic? So the test would work on any distro.

review: Needs Fixing
Revision history for this message
Jack Fromm (jjfrv8) wrote : Posted in a previous version of this proposal

This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

I know, i'm just saying that's another thing that needs fixing

On Tue, Aug 6, 2013 at 10:10 AM, Jack Fromm <email address hidden> wrote:
> This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Elfy (elfy) wrote : Posted in a previous version of this proposal

Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

AFAIK, unless something has to not be flavour agnostic, it should be.

On Tue, Aug 6, 2013 at 4:16 PM, Elfy <email address hidden> wrote:
> Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Elfy (elfy) wrote : Posted in a previous version of this proposal

To be fair, it is if I remember correctly why I'd written

 <dt>Open Mousepad from menu</dt>

rather than

<dt>Open Mousepad from Menu -> Accessories</dt>

I think that all the tests I've written that aren't XFCE follow that generic convention.

Revision history for this message
Jackson Doak (noskcaj) wrote : Posted in a previous version of this proposal

Yeah, the first option i fine, although i prefer (just an opinion)
<dt>Open Mousepad</dt>

On Tue, Aug 6, 2013 at 4:38 PM, Elfy <email address hidden> wrote:
> To be fair, it is if I remember correctly why I'd written
>
> <dt>Open Mousepad from menu</dt>
>
> rather than
>
> <dt>Open Mousepad from Menu -> Accessories</dt>
>
> I think that all the tests I've written that aren't XFCE follow that generic convention.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

Revision history for this message
Jackson Doak (noskcaj) wrote :

Looks good. I'll wait for elfy to check it too though.

review: Approve
Revision history for this message
Elfy (elfy) wrote :

ok with me - thanks both

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testcases/packages/1557_Mousepad'
2--- testcases/packages/1557_Mousepad 2013-07-26 13:34:54 +0000
3+++ testcases/packages/1557_Mousepad 2013-08-06 21:19:23 +0000
4@@ -1,6 +1,6 @@
5 This test will check that Mousepad opens
6 <dl>
7- <dt>Open Mousepad from menu</dt>
8+ <dt>Open Mousepad</dt>
9 <dd>Mousepad opens with an unnamed text document</dd>
10 </dl>
11
12@@ -8,63 +8,66 @@
13 <dl>
14 <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
15 <dd>Text appears in window</dd>
16- <dt>Click File - Save</dt>
17+ <dt>Click File -> Save</dt>
18 <dd>Save As window opens</dd>
19- <dt>type test.txt in Name box</dt>
20+ <dt>Type test.txt in Name: box</dt>
21 <dt>Select any folder to save file to</dt>
22 <dd>Chosen file name and target folder remain as selected</dd>
23 <dt>Click Save button</dt>
24 <dd>Save as dialogue closes</dd>
25- <dt>Close Mousepad with File - Close Window</dt>
26+ <dt>Close Mousepad with File -> Close Window</dt>
27 <dd>Mousepad closes</dd>
28- <dt>Open File Manager from Menu - Accessories, navigate to saved file and double click to open in Mousepad</dt>
29+ <dt>Open File Manager, navigate to saved file and double click to open in Mousepad</dt>
30 <dd>Mousepad opens with saved text</dd>
31 </dl>
32
33 This test will check that Mousepad can find and highlight searched text
34 <dl>
35- <dt>Open Mousepad from menu</dt>
36+ <dt>Open Mousepad</dt>
37 <dd>Mousepad opens with an unnamed text document</dd>
38 <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
39 <dd>Text appears in window</dd>
40 <dt>Press Ctrl+F</dt>
41 <dd>Search box appears</dd>
42- <dt>Type t in the box</dt>
43- <dd>First t is found in the text document</dd>
44- <dt>Press F3</dt>
45- <dd>Next t is found in the text document</dd>
46- <dt>Type he in the search box</dt>
47- <dd>The is found in the document</dd>
48- <dt>Press F3</dt>
49- <dd>Next the is found in the document</dd>
50+ <dt>Type "t" in the box</dt>
51+ <dd>First "t" is found in the text document</dd>
52+ <dt>Press F3</dt>
53+ <dd>Next "t" is found in the text document</dd>
54+ <dt>Type "he" in the search box</dt>
55+ <dd>"The" is found in the document with the search term highlighted</dd>
56+ <dt>Press F3</dt>
57+ <dd>Next "the" is found in the document</dd>
58 <dt>Press esc</dt>
59 <dd>Search box closes, focus returns to text document with search term highlighted</dd>
60 </dl>
61
62 This test will check that Mousepad can find and replace text, including case sensitivity and saves on close
63 <dl>
64- <dt>Open Mousepad from menu</dt>
65+ <dt>Open Mousepad</dt>
66 <dd>Mousepad opens with an unnamed text document</dd>
67 <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
68 <dd>Text appears in window</dd>
69 <dt>Press Ctrl+R</dt>
70 <dd>Replace dialogue opens</dd>
71- <dt>Type fox in the search for box</dt>
72- <dt>Type cat in the replace with box and click Replace All</dt>
73+ <dt>Type "fox" in the Search for: box</dt>
74+ <dt>Type "cat" in the Replace with: box
75+ <dt>Check the Replace all in: option</dt>
76+ <dd>1 occurence is found and the Replace button changes to say Replace All</dd>
77+ <dt>Click Replace All</dt>
78 <dd>Replace dialogue does not close</dd>
79 <dd>Text now reads "The quick brown cat jumps over the lazy dog"</dd>
80- <dt>Type the in the search for box</dt>
81- <dt>Type a in the replace with box</dt>
82- <dt>Click Case Sensitive box and click Replace All</dt>
83+ <dt>Type "the" in the Search for: box</dt>
84+ <dt>Type "a" in the Replace with: box</dt>
85+ <dt>Check the Case sensitive option and click the Replace All button</dt>
86 <dd>Replace dialogue does not close</dd>
87 <dd>Text now reads "The quick brown cat jumps over a lazy dog"</dd>
88- <dt>Click Close in Replace box</dt>
89- <dd>Replace box closes</dd>
90- <dt>Close Mousepad with File - Close Window</dt>
91+ <dt>Click Close button in Replace dialogue</dt>
92+ <dd>Replace dialogue closes</dd>
93+ <dt>Close Mousepad with File -> Close Window</dt>
94 <dd>Save before closing dialogue appears</dd>
95 <dt>Click Save</dt>
96 <dd>Mousepad closes</dd>
97- <dt>Open File Manager from Menu - Accessories, navigate to saved file and double click to open in Mousepad</dt>
98+ <dt>Open File Manager, navigate to saved file and double click to open in Mousepad</dt>
99 <dd>Mousepad opens with saved text</dd>
100 </dl>
101
102
103=== modified file 'testcases/packages/1558_Xfce4 Terminal'
104--- testcases/packages/1558_Xfce4 Terminal 2013-07-26 13:21:53 +0000
105+++ testcases/packages/1558_Xfce4 Terminal 2013-08-06 21:19:23 +0000
106@@ -10,7 +10,7 @@
107 <dl>
108 <dt>Hit Alt-F2 keys</dt>
109 <dd>An Application Finder window opens</dd>
110- <dt>Type Xfce Terminal in the window text box</dt>
111+ <dt>Type "xfce4-terminal" in the window text box</dt>
112 <dd>The Launch button is now enabled and click-able</dd>
113 <dt>Click the Launch button</dt>
114 <dd>A terminal window opens with default settings displaying a command prompt, and the cursor is positioned at the command prompt</dd>
115@@ -22,15 +22,15 @@
116 <dd>A terminal window opens with default settings displaying a command prompt, and the cursor is positioned at the command prompt</dd>
117 </dl>
118
119-This test will check that Xfce4 Terminal opens a new terminal window from a already open terminal window by right clicking on it
120+This test will check that Xfce4 Terminal opens a new terminal window from an already open terminal window by right clicking on it
121 <dl>
122- <dt>Open a terminal window, point your mouse cursor to it then press the right mouse button</dt>
123+ <dt>Open a terminal window, point your mouse cursor to it, then press the right mouse button</dt>
124 <dd>A popup menu appears</dd>
125 <dt>Select the Open Terminal option</dt>
126 <dd>A new terminal window opens, inheriting the working directory from its parent terminal</dd>
127 </dl>
128
129-This test will check that Xfce4 Terminal opens a new terminal window from the menubar of a already open terminal window
130+This test will check that Xfce4 Terminal opens a new terminal window from the menubar of an already open terminal window
131 <dl>
132 <dt>Open a terminal window and click File on the menubar</dt>
133 <dd>A menu drops down</dd>
134@@ -94,7 +94,7 @@
135 <dt>Select the Set Title... option</dt>
136 <dd>Set Title dialog opens</dd>
137 <dt>Type the new title in the Title text box</dt>
138- <dd>Terminal applys the change immediately</dd>
139+ <dd>Terminal applies the change immediately</dd>
140 </dl>
141
142 This test will check that Xfce4 Terminal hides the menubar
143@@ -105,7 +105,7 @@
144 <dd>The Terminal menubar hides</dd>
145 </dl>
146
147-This test will check that Xfce4 Terminal show a hidden menubar
148+This test will check that Xfce4 Terminal shows a hidden menubar
149 <dl>
150 <dt>Open a terminal window and click on View on the menubar</dt>
151 <dd>A menu drops down</dd>
152@@ -118,12 +118,12 @@
153 </dl>
154
155 This test will check that Xfce4 Terminal maximizes into fullscreen
156-<dt>
157+<dl>
158 <dt>Open a terminal window then click on View on the menubar</dt>
159 <dd>A menu drops down</dd>
160 <dt>Select the Fullscreen option</dt>
161 <dd>The Terminal window maximizes into fullscreen</dd>
162-</dt>
163+</dl>
164
165 <strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
166 If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> 'failed' and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>

Subscribers

People subscribed via source and target branches