Merge lp:~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests

[Jack Fromm]

    Mousepad test: made some readability changes (e.g., adding quotes to typed text)
    and added a missing step to search-replace instructions.

    Xfce4 Terminal: corrected some typos, fixed a dangling paragraph, replaced
    non-working search term in Alt-F2 section.

[Jackson Doak (noskcaj)]

Can you make the test flavour agnostic? So the test would work on any distro.

review: Needs Fixing

[Jack Fromm (jjfrv8)]

This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.

[Jackson Doak (noskcaj)]

I know, i'm just saying that's another thing that needs fixing

On Tue, Aug 6, 2013 at 10:10 AM, Jack Fromm <email address hidden> wrote:
> This is not a new test. I'm just modifying the one that's already on the qatracker. Elfy requested that the first one to run it check it for technical accuracy.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

[Elfy (elfy)]

Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic

[Jackson Doak (noskcaj)]

AFAIK, unless something has to not be flavour agnostic, it should be.

On Tue, Aug 6, 2013 at 4:16 PM, Elfy <email address hidden> wrote:
> Not so it's strictly necessary given that these tests are for people testing flavours and their default apps, or should a testcase for unity be written so it's flavour agnostic
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

[Elfy (elfy)]

To be fair, it is if I remember correctly why I'd written

 <dt>Open Mousepad from menu</dt>

rather than

<dt>Open Mousepad from Menu -> Accessories</dt>

I think that all the tests I've written that aren't XFCE follow that generic convention.

[Jackson Doak (noskcaj)]

Yeah, the first option i fine, although i prefer (just an opinion)
<dt>Open Mousepad</dt>

On Tue, Aug 6, 2013 at 4:38 PM, Elfy <email address hidden> wrote:
> To be fair, it is if I remember correctly why I'd written
>
> <dt>Open Mousepad from menu</dt>
>
> rather than
>
> <dt>Open Mousepad from Menu -> Accessories</dt>
>
> I think that all the tests I've written that aren't XFCE follow that generic convention.
> --
> https://code.launchpad.net/~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised/+merge/178646
> You are reviewing the proposed merge of lp:~jjfrv8-gmail/ubuntu-manual-tests/Xfce4Terminal-revised into lp:ubuntu-manual-tests.

[lp:~jjfrv8/ubuntu-manual-tests/Xfce4Terminal-revised]

205. By Jack Fromm <email address hidden> on 2013-08-06

Changed "Open" instructions become flavor-agnostic.

Unmerged revisions

=== modified file 'testcases/packages/1557_Mousepad'
--- testcases/packages/1557_Mousepad	2013-07-26 13:34:54 +0000
+++ testcases/packages/1557_Mousepad	2013-08-06 21:15:36 +0000
@@ -1,6 +1,6 @@
 This test will check that Mousepad opens
 <dl>
-    <dt>Open Mousepad from menu</dt>
+    <dt>Open Mousepad</dt>
         <dd>Mousepad opens with an unnamed text document</dd>
 </dl>
 
@@ -8,63 +8,66 @@
 <dl>
     <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
         <dd>Text appears in window</dd>
-    <dt>Click File - Save</dt>
+    <dt>Click File -> Save</dt>
         <dd>Save As window opens</dd>
-    <dt>type test.txt in Name box</dt>
+    <dt>Type test.txt in Name: box</dt>
     <dt>Select any folder to save file to</dt>
         <dd>Chosen file name and target folder remain as selected</dd>
     <dt>Click Save button</dt>
         <dd>Save as dialogue closes</dd>
-    <dt>Close Mousepad with File - Close Window</dt>
+    <dt>Close Mousepad with File -> Close Window</dt>
         <dd>Mousepad closes</dd>
-    <dt>Open File Manager from Menu - Accessories, navigate to saved file and double click to open in Mousepad</dt>
+    <dt>Open File Manager, navigate to saved file and double click to open in Mousepad</dt>
         <dd>Mousepad opens with saved text</dd>
 </dl>
 
 This test will check that Mousepad can find and highlight searched text
 <dl>
-    <dt>Open Mousepad from menu</dt>
+    <dt>Open Mousepad</dt>
         <dd>Mousepad opens with an unnamed text document</dd>
     <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
         <dd>Text appears in window</dd>
     <dt>Press Ctrl+F</dt>
         <dd>Search box appears</dd>
-    <dt>Type t in the box</dt>
-        <dd>First t is found in the text document</dd>
-    <dt>Press F3</dt>
-        <dd>Next t is found in the text document</dd>
-    <dt>Type he in the search box</dt>
-        <dd>The is found in the document</dd>
-    <dt>Press F3</dt>
-        <dd>Next the is found in the document</dd>
+    <dt>Type "t" in the box</dt>
+        <dd>First "t" is found in the text document</dd>
+    <dt>Press F3</dt>
+        <dd>Next "t" is found in the text document</dd>
+    <dt>Type "he" in the search box</dt>
+        <dd>"The" is found in the document with the search term highlighted</dd>
+    <dt>Press F3</dt>
+        <dd>Next "the" is found in the document</dd>
     <dt>Press esc</dt>
         <dd>Search box closes, focus returns to text document with search term highlighted</dd>
 </dl>
 
 This test will check that Mousepad can find and replace text, including case sensitivity and saves on close
 <dl>
-    <dt>Open Mousepad from menu</dt>
+    <dt>Open Mousepad</dt>
         <dd>Mousepad opens with an unnamed text document</dd>
     <dt>Type in "The quick brown fox jumps over the lazy dog"</dt>
         <dd>Text appears in window</dd>
     <dt>Press Ctrl+R</dt>
         <dd>Replace dialogue opens</dd>
-    <dt>Type fox in the search for box</dt>
-    <dt>Type cat in the replace with box and click Replace All</dt>
+    <dt>Type "fox" in the Search for: box</dt>
+    <dt>Type "cat" in the Replace with: box
+    <dt>Check the Replace all in: option</dt>
+        <dd>1 occurence is found and the Replace button changes to say Replace All</dd>
+    <dt>Click Replace All</dt>
         <dd>Replace dialogue does not close</dd>
         <dd>Text now reads "The quick brown cat jumps over the lazy dog"</dd>
-    <dt>Type the in the search for box</dt>
-    <dt>Type a in the replace with box</dt>
-    <dt>Click Case Sensitive box and click Replace All</dt>
+    <dt>Type "the" in the Search for: box</dt>
+    <dt>Type "a" in the Replace with: box</dt>
+    <dt>Check the Case sensitive option and click the Replace All button</dt>
         <dd>Replace dialogue does not close</dd>
         <dd>Text now reads "The quick brown cat jumps over a lazy dog"</dd>
-    <dt>Click Close in Replace box</dt>
-        <dd>Replace box closes</dd>
-    <dt>Close Mousepad with File - Close Window</dt>
+    <dt>Click Close button in Replace dialogue</dt>
+        <dd>Replace dialogue closes</dd>
+    <dt>Close Mousepad with File -> Close Window</dt>
         <dd>Save before closing dialogue appears</dd>
     <dt>Click Save</dt>
         <dd>Mousepad closes</dd>
-    <dt>Open File Manager from Menu - Accessories, navigate to saved file and double click to open in Mousepad</dt>
+    <dt>Open File Manager, navigate to saved file and double click to open in Mousepad</dt>
         <dd>Mousepad opens with saved text</dd>
 </dl>
 

=== modified file 'testcases/packages/1558_Xfce4 Terminal'
--- testcases/packages/1558_Xfce4 Terminal	2013-07-26 13:21:53 +0000
+++ testcases/packages/1558_Xfce4 Terminal	2013-08-06 21:15:36 +0000
@@ -10,7 +10,7 @@
 <dl>
     <dt>Hit Alt-F2 keys</dt>
         <dd>An Application Finder window opens</dd>
-    <dt>Type Xfce Terminal in the window text box</dt>
+    <dt>Type "xfce4-terminal" in the window text box</dt>
         <dd>The Launch button is now enabled and click-able</dd>
     <dt>Click the Launch button</dt>
         <dd>A terminal window opens with default settings displaying a command prompt, and the cursor is positioned at the command prompt</dd>
@@ -22,15 +22,15 @@
         <dd>A terminal window opens with default settings displaying a command prompt, and the cursor is positioned at the command prompt</dd>
 </dl>
 
-This test will check that Xfce4 Terminal opens a new terminal window from a already open terminal window by right clicking on it
+This test will check that Xfce4 Terminal opens a new terminal window from an already open terminal window by right clicking on it
 <dl>    
-    <dt>Open a terminal window, point your mouse cursor to it then press the right mouse button</dt>
+    <dt>Open a terminal window, point your mouse cursor to it, then press the right mouse button</dt>
         <dd>A popup menu appears</dd>
     <dt>Select the Open Terminal option</dt>
         <dd>A new terminal window opens, inheriting the working directory from its parent terminal</dd>
 </dl>
 
-This test will check that Xfce4 Terminal opens a new terminal window from the menubar of a already open terminal window
+This test will check that Xfce4 Terminal opens a new terminal window from the menubar of an already open terminal window
 <dl>    
     <dt>Open a terminal window and click File on the menubar</dt>
         <dd>A menu drops down</dd>
@@ -94,7 +94,7 @@
     <dt>Select the Set Title... option</dt>
         <dd>Set Title dialog opens</dd>
     <dt>Type the new title in the Title text box</dt>
-        <dd>Terminal applys the change immediately</dd>
+        <dd>Terminal applies the change immediately</dd>
 </dl>
 
 This test will check that Xfce4 Terminal hides the menubar
@@ -105,7 +105,7 @@
         <dd>The Terminal menubar hides</dd>
 </dl>
 
-This test will check that Xfce4 Terminal show a hidden menubar
+This test will check that Xfce4 Terminal shows a hidden menubar
 <dl>
     <dt>Open a terminal window and click on View on the menubar</dt>
         <dd>A menu drops down</dd>
@@ -118,12 +118,12 @@
 </dl>
 
 This test will check that Xfce4 Terminal maximizes into fullscreen
-<dt>
+<dl>
     <dt>Open a terminal window then click on View on the menubar</dt>
         <dd>A menu drops down</dd>
     <dt>Select the Fullscreen option</dt>
         <dd>The Terminal window maximizes into fullscreen</dd>
-</dt>
+</dl>
 
 <strong>If all actions produce the expected results listed, please <a href="results#add_result">submit</a> a 'passed' result.
     If an action fails, or produces an unexpected result, please <a href="results#add_result">submit</a> 'failed' and <a href="../../buginstructions">file a bug</a>. Please be sure to include the bug number when you <a href="results#add_result">submit</a> your result</strong>