Merge lp:~jjesse/ubuntu/quantal/libxapool-java/typo-fix into lp:ubuntu/quantal/libxapool-java

Proposed by Jonathan Jesse
Status: Work in progress
Proposed branch: lp:~jjesse/ubuntu/quantal/libxapool-java/typo-fix
Merge into: lp:ubuntu/quantal/libxapool-java
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~jjesse/ubuntu/quantal/libxapool-java/typo-fix
Reviewer Review Type Date Requested Status
Michael Terry Disapprove
Ubuntu branches Pending
Review via email: mp+125542@code.launchpad.net

Description of the change

changed typo in control file

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Thanks for the patch! This will sound familiar to you from the other merge request, but this typo doesn't seem worth a delta from Debian.

Some nits about your patch:
* You use precise in the changelog, but it should have been quantal
* Keep the changelog text on the same line as the asterisk

I'll reject the merge request for Ubuntu. But if you fix this patch up, it should be passed on to Debian.

https://wiki.ubuntu.com/Debian/ForUbuntuDevelopers#Forwarding_bug_reports

Or maybe another solution would be to fix the typo in the English translation? https://translations.launchpad.net/ddtp-ubuntu/+translations

Thanks!

review: Disapprove

Unmerged revisions

6. By Jonathan Jesse

changed typo in control file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-04-15 17:28:06 +0000
3+++ debian/changelog 2012-09-20 17:14:53 +0000
4@@ -1,3 +1,9 @@
5+libxapool-java (1.5.0-3ubuntu1) precise; urgency=low
6+
7+ *
8+ fixed typo by changing allows to too allows one to in debian/control
9+ -- Jonathan <jjesse@gmail.com> Sun, 02 Sep 2012 17:09:22 -0400
10+
11 libxapool-java (1.5.0-3) unstable; urgency=low
12
13 [ Michael Koch ]
14
15=== modified file 'debian/control'
16--- debian/control 2010-04-15 17:28:06 +0000
17+++ debian/control 2012-09-20 17:14:53 +0000
18@@ -13,7 +13,7 @@
19 Architecture: all
20 Depends: ${shlibs:Depends}, ${misc:Depends}
21 Description: connection pooling for JDBC
22- XAPool is a software component which allows to:
23+ XAPool is a software component which allows one to:
24 .
25 - Store objects with a Generic Pool
26 - Export a DataSource (javax.sql.DataSource)

Subscribers

People subscribed via source and target branches