Merge lp:~jjesse/ubuntu/quantal/cobalt-panel-utils/homepage-fix into lp:ubuntu/quantal/cobalt-panel-utils

[Jonathan Jesse]

Fixing typo change

[Michael Terry (mterry)]

Thanks for the patch! But it doesn't seem worth a delta from Debian (and the homepage doesn't even exist?). It doesn't look to me like Debian has the field, as you say. At least I don't see it in their packaging (we are using the latest from Debian).

Also, some nits about your patch:
* You use precise in the changelog, but it should have been quantal
* Keep the changelog text on the same line as the asterisk
* You dropped the blank line in debian/control, but it is important. Homepage should be stuck on the end of the top stanza (describing the source package), then there should be a blank line, then the bottom stanza (the binary package).

I'll reject the merge request for Ubuntu. But if you fix this patch up, it should be passed on to Debian.

https://wiki.ubuntu.com/Debian/ForUbuntuDevelopers#Forwarding_bug_reports

Thanks!

review: Disapprove

[Jonathan Jesse (jjesse)]

Michael,

Thanks for the kind words, I found this through the typo-fix portion that
Daniel posted on his blog.

I'm trying to learn how to fix these so thanks again for being patient with
me.
Should I report this as a bug in debian via the "submittodebian" tool
instead of a bzr branch?

Thanks again for the help,

Jonathan

On Thu, Oct 4, 2012 at 12:19 PM, Michael Terry
<email address hidden>wrote:

> Review: Disapprove
>
> Thanks for the patch! But it doesn't seem worth a delta from Debian (and
> the homepage doesn't even exist?). It doesn't look to me like Debian has
> the field, as you say. At least I don't see it in their packaging (we are
> using the latest from Debian).
>
> Also, some nits about your patch:
> * You use precise in the changelog, but it should have been quantal
> * Keep the changelog text on the same line as the asterisk
> * You dropped the blank line in debian/control, but it is important.
> Homepage should be stuck on the end of the top stanza (describing the
> source package), then there should be a blank line, then the bottom stanza
> (the binary package).
>
> I'll reject the merge request for Ubuntu. But if you fix this patch up,
> it should be passed on to Debian.
>
> https://wiki.ubuntu.com/Debian/ForUbuntuDevelopers#Forwarding_bug_reports
>
> Thanks!
> --
>
> https://code.launchpad.net/~jjesse/ubuntu/quantal/cobalt-panel-utils/homepage-fix/+merge/125538
> You are the owner of
> lp:~jjesse/ubuntu/quantal/cobalt-panel-utils/homepage-fix.
>

[Michael Terry (mterry)]

Yeah, submittodebian would be perfect for this. I use it myself for passing things on to Debian.

Unmerged revisions

3. By Jonathan Jesse on 2012-09-04

added homepage field that was missing

=== modified file 'debian/changelog'
--- debian/changelog	2006-09-23 17:58:08 +0000
+++ debian/changelog	2012-09-20 17:13:37 +0000
@@ -1,3 +1,10 @@
+cobalt-panel-utils (1.0.2-3ubuntu1) precise; urgency=low
+
+   * 
+   Homepage field was missing, but it was present in the debian build (packages.debian.org/sid/cobalt-panel-utils
+   Added homepage
+ -- Jonathan <jonathan@netbook>  Mon, 03 Sep 2012 22:22:26 -0400
+
 cobalt-panel-utils (1.0.2-3) unstable; urgency=low
 
   * Fix bad architectures list. 

=== modified file 'debian/control'
--- debian/control	2006-09-23 17:58:08 +0000
+++ debian/control	2012-09-20 17:13:37 +0000
@@ -4,7 +4,7 @@
 Maintainer: Adam Cécile (Le_Vert) <[e-mail]>
 Build-Depends: debhelper (>= 5), dpatch
 Standards-Version: 3.7.2
-
+Homepage: http://gentoo.404ster.com/
 Package: cobalt-panel-utils
 Architecture: i386 mipsel
 Depends: ${shlibs:Depends}