Hi, I've checked again this branch against the new trunk, and while the behavior looks good (probably the 1sec delay duration can be discussed with design, but the code is fine), the tests need some tuning while the merge conflicts should be resolved:
Instead of self.assertTrue/assertFalse when possible use:
self.assertThat(introspection.value, Eventually(Equals(True)))
Then move your tests into LauncherTooltipTests that
Also, probabily the HUD / BFB launcher icons special code to override the tooltip show, could be replaced by your codepath, that is more general and I guess can implement LauncherTestCase and define in its setUp self.set_unity_option('launcher_hide_mode', 0)
Hi, I've checked again this branch against the new trunk, and while the behavior looks good (probably the 1sec delay duration can be discussed with design, but the code is fine), the tests need some tuning while the merge conflicts should be resolved:
Instead of self.assertTrue /assertFalse when possible use: assertThat( introspection. value, Eventually( Equals( True)))
self.
Then move your tests into LauncherTooltip Tests that
Also, probabily the HUD / BFB launcher icons special code to override the tooltip show, could be replaced by your codepath, that is more general and I guess can implement LauncherTestCase and define in its setUp self.set_ unity_option( 'launcher_ hide_mode' , 0)