Merge lp:~jjed/software-center/spinner-fix into lp:software-center

Proposed by Jjed on 2011-08-25
Status: Merged
Merged at revision: 2219
Proposed branch: lp:~jjed/software-center/spinner-fix
Merge into: lp:software-center
Diff against target: 20 lines (+4/-0)
1 file modified
softwarecenter/ui/gtk3/panes/softwarepane.py (+4/-0)
To merge this branch: bzr merge lp:~jjed/software-center/spinner-fix
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve on 2011-08-29
Michael Vogt 2011-08-25 Pending
Review via email: mp+72966@code.launchpad.net

Description of the change

Fixes the gtk3 spinner view, making USC feel more responsive. The problem was incorrect Gtk.Notebook pagination.

To post a comment you must log in.
Gary Lasker (gary-lasker) wrote :

Thanks very much for your branch, Jacob! Looks good and I'll merge it now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/panes/softwarepane.py'
2--- softwarecenter/ui/gtk3/panes/softwarepane.py 2011-08-25 18:51:39 +0000
3+++ softwarecenter/ui/gtk3/panes/softwarepane.py 2011-08-25 22:14:39 +0000
4@@ -211,12 +211,16 @@
5 if not "SOFTWARE_CENTER_DEBUG_TABS" in os.environ:
6 self.notebook.set_show_tabs(False)
7 self.notebook.set_show_border(False)
8+ # an empty notebook, where the details view will eventually go
9+ self.details_notebook = Gtk.Notebook()
10+ self.details_notebook.set_show_border(False)
11 # make a spinner view to display while the applist is loading
12 self.spinner_view = SpinnerView()
13 self.spinner_notebook = Gtk.Notebook()
14 self.spinner_notebook.set_show_tabs(False)
15 self.spinner_notebook.set_show_border(False)
16 self.spinner_notebook.append_page(self.notebook, None)
17+ self.spinner_notebook.append_page(self.details_notebook, None)
18 self.spinner_notebook.append_page(self.spinner_view, None)
19
20 self.pack_start(self.spinner_notebook, True, True, 0)

Subscribers

People subscribed via source and target branches