overlay-scrollbar

Merge lp:~jjardon/overlay-scrollbar/fix-728418 into lp:overlay-scrollbar

  1. fix-728418
  2. Merge into trunk
Proposed by Javier Jardón
Status: Merged
Merged at revision: 170
Proposed branch: lp:~jjardon/overlay-scrollbar/fix-728418
Merge into: lp:overlay-scrollbar
Diff against target: 13 lines (+2/-1)
1 file modified
os/os-thumb.c (+2/-1)
To merge this branch: bzr merge lp:~jjardon/overlay-scrollbar/fix-728418
Reviewer Review Type Date Requested Status
Andrea Cimitan Approve
Review via email: mp+54332@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Javier Jardón (jjardon) wrote :

With this little patch, the performance of the os-scrollbars ~= the performance of normal GTK+ scrollbars

Revision history for this message
Andrea Cimitan (cimi) wrote :

this is just AWESOME! you figured out what was causing the slowdown, this patch fixes it completely.
Very very well done.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-thumb.c'
2--- os/os-thumb.c 2011-03-18 16:33:28 +0000
3+++ os/os-thumb.c 2011-03-22 12:04:28 +0000
4@@ -147,7 +147,8 @@
5 gtk_widget_set_app_paintable (GTK_WIDGET (thumb), TRUE);
6 gtk_widget_add_events (GTK_WIDGET (thumb), GDK_BUTTON_PRESS_MASK |
7 GDK_BUTTON_RELEASE_MASK |
8- GDK_POINTER_MOTION_MASK);
9+ GDK_BUTTON_MOTION_MASK |
10+ GDK_POINTER_MOTION_HINT_MASK);
11
12 os_thumb_screen_changed (GTK_WIDGET (thumb), NULL);
13 os_thumb_composited_changed (GTK_WIDGET (thumb));

Subscribers

People subscribed via source and target branches