Merge lp:~jjardon/libappindicator/fix-autotools into lp:libappindicator

Proposed by Javier Jardón
Status: Merged
Approved by: Ted Gould
Approved revision: 207
Merged at revision: 206
Proposed branch: lp:~jjardon/libappindicator/fix-autotools
Merge into: lp:libappindicator
Diff against target: 136 lines (+25/-30)
2 files modified
Makefile.am (+2/-0)
configure.ac (+23/-30)
To merge this branch: bzr merge lp:~jjardon/libappindicator/fix-autotools
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+64705@code.launchpad.net

Description of the change

Update autotools configuration

Do not use deprecated macros
Use new libtool syntax
Remove non needed code
Use xz and pax for tarballs

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

We still need gz and not xz, fixed that and committed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.am'
2--- Makefile.am 2010-12-02 20:38:40 +0000
3+++ Makefile.am 2011-06-15 15:54:25 +0000
4@@ -1,3 +1,5 @@
5+ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
6+
7 SUBDIRS = \
8 src \
9 bindings \
10
11=== modified file 'configure.ac'
12--- configure.ac 2011-03-23 20:08:56 +0000
13+++ configure.ac 2011-06-15 15:54:25 +0000
14@@ -1,24 +1,28 @@
15-
16-AC_INIT(libappindicator, 0.3.0, ted@canonical.com)
17+AC_INIT([libappindicator],
18+ [0.3.0],
19+ [http://bugs.launchpad.net/libappindicator],
20+ [libappindicator],
21+ [http://launchpad.net/libappindicator])
22 AC_COPYRIGHT([Copyright 2009, 2010 Canonical])
23
24-AC_PREREQ(2.53)
25-
26-AM_CONFIG_HEADER(config.h)
27-AM_INIT_AUTOMAKE(libappindicator, 0.3.0)
28-
29-AM_MAINTAINER_MODE
30-
31-AC_ISC_POSIX
32+AC_PREREQ([2.64])
33+
34+AC_CONFIG_HEADERS([config.h])
35+AC_CONFIG_MACRO_DIR([m4])
36+
37+AM_INIT_AUTOMAKE([1.11 -Wall tar-ustar no-dist-gzip dist-xz])
38+
39+AM_MAINTAINER_MODE([enable])
40+
41+AM_SILENT_RULES([yes])
42+
43+# Check for programs
44 AC_PROG_CC
45 AM_PROG_CC_C_O
46-AC_STDC_HEADERS
47-AC_PROG_LIBTOOL
48-
49-AC_SUBST(VERSION)
50-AC_CONFIG_MACRO_DIR([m4])
51-
52-m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])
53+
54+# Initialize libtool
55+LT_PREREQ([2.2])
56+LT_INIT
57
58 AC_PATH_PROG([GLIB_MKENUMS], [glib-mkenums])
59 AC_PATH_PROG([GLIB_GENMARSHAL], [glib-genmarshal])
60@@ -30,7 +34,6 @@
61 ###########################
62
63 GTK_DOC_CHECK([1.9])
64-AC_CONFIG_MACRO_DIR(m4)
65
66
67 ###########################
68@@ -56,8 +59,6 @@
69 gio-2.0 >= $GIO_REQUIRED_VERSION
70 indicator3 >= $INDICATOR_REQUIRED_VERSION
71 dbusmenu-gtk3-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
72- AC_SUBST(LIBRARY_CFLAGS)
73- AC_SUBST(LIBRARY_LIBS)
74 AC_DEFINE(HAVE_GTK3, 1, [whether gtk3 is available])
75 ],
76 [test "x$with_gtk" = x2],
77@@ -66,16 +67,12 @@
78 gio-2.0 >= $GIO_REQUIRED_VERSION
79 indicator >= $INDICATOR_REQUIRED_VERSION
80 dbusmenu-gtk-0.4 >= $DBUSMENUGTK_REQUIRED_VERSION)
81- AC_SUBST(LIBRARY_CFLAGS)
82- AC_SUBST(LIBRARY_LIBS)
83 ],
84 [AC_MSG_FAILURE([Value for --with-gtk was neither 2 nor 3])]
85 )
86 AM_CONDITIONAL(USE_GTK3, [test "x$with_gtk" = x3])
87
88 PKG_CHECK_MODULES(TESTDEPS, dbus-glib-1)
89-AC_SUBST(TESTDEPS_CFLAGS)
90-AC_SUBST(TESTDEPS_LIBS)
91
92 ###########################
93 # GObject Introspection
94@@ -147,8 +144,6 @@
95 GLIB_SHARP_REQ_VERSION=2.12.1
96 GTK_SHARP_REQ_VERSION=2.12
97 PKG_CHECK_MODULES(GTK_SHARP, gtk-sharp-2.0 >= $GTK_SHARP_REQ_VERSION)
98-AC_SUBST(GTK_SHARP_LIBS)
99-AC_SUBST(GTK_SHARP_CFLAGS)
100
101 PKG_CHECK_MODULES(GAPI, gapi-2.0 >= $GLIB_SHARP_REQ_VERSION)
102 AC_PATH_PROG(GAPI_PARSER, gapi2-parser, no)
103@@ -159,7 +154,6 @@
104 AC_SUBST(GAPI_FIXUP)
105
106 PKG_CHECK_MODULES(NUNIT, nunit >= 2.4.7)
107-AC_SUBST(NUNIT_LIBS)
108
109 ###########################
110 # Check to see if we're local
111@@ -184,8 +178,6 @@
112 gtk+-2.0 >= $GTK_REQUIRED_VERSION
113 pygobject-2.0 >= $PYGOBJECT_REQUIRED
114 ])
115-AC_SUBST(APPINDICATOR_PYTHON_CFLAGS)
116-AC_SUBST(APPINDICATOR_PYTHON_LIBS)
117
118 AC_MSG_CHECKING(for pygtk defs)
119 PYGTK_DEFSDIR=`$PKG_CONFIG --variable=defsdir pygtk-2.0`
120@@ -201,7 +193,7 @@
121 # Files
122 ###########################
123
124-AC_OUTPUT([
125+AC_CONFIG_FILES([
126 Makefile
127 src/Makefile
128 src/appindicator-0.1.pc
129@@ -222,6 +214,7 @@
130 docs/reference/version.xml
131 docs/reference/libappindicator-docs.sgml
132 ])
133+AC_OUTPUT
134
135 ###########################
136 # Results

Subscribers

People subscribed via source and target branches