Merge lp:~jindallo/nearby-scope/convergence-ui-support into lp:nearby-scope
Status: | Merged |
---|---|
Approved by: | Jin on 2016-08-03 |
Approved revision: | 100 |
Merged at revision: | 102 |
Proposed branch: | lp:~jindallo/nearby-scope/convergence-ui-support |
Merge into: | lp:nearby-scope |
Diff against target: |
257 lines (+28/-28) (has conflicts) 1 file modified
click-src/aggregator/child_scopes.json (+28/-28) Contents conflict in click-src/aggregator/libcom.canonical.scopes.aggregator_aggregator.so |
To merge this branch: | bzr merge lp:~jindallo/nearby-scope/convergence-ui-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kyle Nitzsche | 2016-07-12 | Approve on 2016-08-02 | |
NearBy Scope Team | 2016-07-12 | Pending | |
Review via email:
|
Kyle Nitzsche (knitzsche) wrote : | # |
Kyle Nitzsche (knitzsche) wrote : | # |
Hi Jin,
The general approach we discussed is to:
* use high cardinalities to ensure their are enough results to fill in the rows
* limit vertical space in different layouts with collapsed-rows
It seems that this often takes a different approach:
* set collapsed-rows to 0 (which IIRC means show them all without limit)
* limit the number of results with cardinality
Is there a reason you did it this way? Or would you consider doing it the way we discussed?
cheers
Jin (jindallo) wrote : | # |
Hello Kyle,
I used the way we discussed/agreed to implement this patch,
which means:
1. set collapsed-rows to 0 -> 1
2. set cardinality to big enough -> 10
Please kindly have a look on below diff,
it followed the approach we discussed.
Many thanks!
Hi Jin,
I assume you tested:
* in a fake location (like London) that has full results
* on tablet landscape & portrait
* on something small (like krillin)