Ubuntu

Merge lp:~jincreator/ubuntu/precise/language-selector/korean into lp:ubuntu/precise/language-selector

Proposed by Jinkyu Yi on 2012-02-17
Status: Merged
Merged at revision: 184
Proposed branch: lp:~jincreator/ubuntu/precise/language-selector/korean
Merge into: lp:ubuntu/precise/language-selector
Diff against target: 21 lines (+1/-3) 1 file modified
To merge this branch: bzr merge lp:~jincreator/ubuntu/precise/language-selector/korean
Reviewer Review Type Date Requested Status
Martin Pitt 2012-03-15 Approve on 2012-03-16
Gunnar Hjalmarsson (community) 2012-03-15 Approve on 2012-03-16
Sebastien Bacher Needs Information on 2012-03-05
Ubuntu branches 2012-02-17 Pending
Review via email: mp+93535@code.launchpad.net
To post a comment you must log in.
170. By Jinkyu Yi on 2012-03-02

remove nabi thus Unity can't support it

171. By Jinkyu Yi on 2012-03-02

merging

Sebastien Bacher (seb128) wrote :

Thank you for your work, what do you mean "Unity can't support it"? do you have a bug reference?

review: Needs Information
Jinkyu Yi (jincreator) wrote :

As far as I know, Unity get Korean strings correctly from only IBus at now.
In latest Unity, it works as client of IBus(as result of fix bug ##880876).
So Unity depends on IBus and as result, Unity can't support nabi(which use XIM).

For now there is no bug report about using nabi at Unity, but I test it and notice this problem.

One more thing, does my patch need freeze exception to ship in precise?

Gunnar Hjalmarsson (gunnarhj) wrote :

As far as I can tell, the proposed changes make sense.

Jinkyu Yi: If Unity's inability to support nabi is of significance to Korean users, it would be great if you could file a bug about it.

review: Approve
Martin Pitt (pitti) wrote :

Thanks Yi, uploading.

review: Approve

Preview Diff

1=== modified file 'data/pkg_depends'
2--- data/pkg_depends 2012-02-28 08:50:04 +0000
3+++ data/pkg_depends 2012-03-02 15:08:31 +0000
4@@ -153,8 +153,7 @@
5 fn:kn::ttf-kannada-fonts
6 fn:ko::fonts-nanum
7 fn:ko::fonts-nanum-coding
8-fn:ko::fonts-nanum-extra
9-fn:ko::ttf-alee
10+fn:ko::fonts-unfonts-core
11 fn:lo::fonts-lao
12 fn:ml::ttf-malayalam-fonts
13 fn:mn::fonts-manchufont
14@@ -187,7 +186,6 @@
15 # input methods
16 im:ja:ibus:ibus-anthy
17 im:ko:ibus:ibus-hangul
18-im:ko:ibus:nabi
19 im:th:ibus:gtk-im-libthai
20 im:vi:ibus:ibus-unikey
21 im:zh-hans:ibus:ibus-sunpinyin

Subscribers

People subscribed via source and target branches

to all changes: