Merge lp:~jimtremblay-s/placesfiles/placesfiles into lp:placesfiles

Proposed by Jim Tremblay
Status: Approved
Approved by: Jacob Vlijm
Approved revision: 2
Proposed branch: lp:~jimtremblay-s/placesfiles/placesfiles
Merge into: lp:placesfiles
Diff against target: 24 lines (+3/-3)
1 file modified
code/placesfiles_indicator (+3/-3)
To merge this branch: bzr merge lp:~jimtremblay-s/placesfiles/placesfiles
Reviewer Review Type Date Requested Status
Jacob Vlijm Pending
Review via email: mp+328267@code.launchpad.net

Description of the change

To be able to open folder with accentuated characters, all %xx must be converted to there equivalent single character.

Feel free to contact me about changes.

Thanks,
Jim

To post a comment you must log in.
Revision history for this message
Jacob Vlijm (vlijm) wrote :

Hi Jim,

Thanks a lot for the improvement!

Cheers,
Jacob

Revision history for this message
Jim Tremblay (jimtremblay-s) wrote :

Hi Jacob,

I'm not aware of how it works on launchpad, is it me that needs to do the merge?

Thanks,
Jim

Unmerged revisions

2. By Jim Tremblay

Unquote %xx characters in path

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'code/placesfiles_indicator'
2--- code/placesfiles_indicator 2017-02-28 09:19:53 +0000
3+++ code/placesfiles_indicator 2017-07-29 13:12:48 +0000
4@@ -9,6 +9,7 @@
5 import os
6 import subprocess
7 import pftools
8+import urllib.parse
9
10 """
11 Places & Files indicator
12@@ -224,10 +225,9 @@
13 set(loc_bookmarks+defaults+netw_bookmarks))])
14
15 def replace_sc(self, path):
16- for c in [("%23", "#"), ("%5D", "]"), ("%5E", "^"),
17- ("file://", ""), ("%20", " "), ("'", "'")]:
18+ for c in [("file://", ""), ("'", "'")]:
19 path = path.replace(c[0], c[1])
20- return path
21+ return urllib.parse.unquote(path)
22
23 def execute(self, command):
24 subprocess.Popen(command)

Subscribers

People subscribed via source and target branches

to all changes: