lp:~jimbaker/pyjuju/must-specify-relation-name

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:pyjuju at revision 519

Juju Engineering: Pending requested 2012-04-06

Diff: 188 lines (+72/-11)

4 files modified

juju/hooks/commands.py (+11/-3)
juju/hooks/protocol.py (+16/-2)
juju/hooks/tests/test_communications.py (+16/-2)
juju/hooks/tests/test_invoker.py (+29/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #974650: relation-ids should default to $JUJU_RELATION, or if not available, raise an error

Undecided

Fix Released

Link a bug report

Related blueprints

516. By Jim Baker on 2012-04-10

Client side check

515. By Jim Baker on 2012-04-06

relation-ids without an arg defaults to ; raises error if unset

514. By Jim Baker on 2012-04-05

merge relation-id-option [r=hazmat][f=965845]

Adds -r option to specify the relation id for these relation hook
commands: relation-get, relation-set, and relation-list.

513. By Jim Baker on 2012-04-05

merge relation-ids-command [r=hazmat][f=963643]

Implments the relation-ids hook command.

512. By Kapil Thangavelu on 2012-04-04

[trivial] tweak cli help options for consistency/formatting

511. By William Reade on 2012-04-04

When extracting charms, use only filetype mode bits to detect symlinkicity

We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.

R=hazmat
CC=
https://codereview.appspot.com/5980045

510. By Jim Baker on 2012-04-04

merge relation-hook-context [r=hazmat][f=963642]

Implements caching and then looking up child relation hook contexts by
relation ident, along with enumerating relation idents, on a given
parent hook context.

509. By Kapil Thangavelu on 2012-04-04

[trivial] change deploy output when using charm store [r=niemeyer]

508. By Kapil Thangavelu on 2012-03-30

[trivial] juju only initializes the sample when given a command, post cli parsing

507. By Jim Baker on 2012-03-30

merge relation-id [r=hazmat][f=963640]

Implments relation id support (code calls this relation ident) to
unambiguously refer to relations.