Code review comment for lp:~jimbaker/juju/unit-rel-lifecycle-start-invoker

Kapil Thangavelu (hazmat) wrote :

lgtm

https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecycle.py
File juju/unit/tests/test_lifecycle.py (right):

https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecycle.py#newcode901
juju/unit/tests/test_lifecycle.py:901: for i in xrange(1, 3):
don't use xrange, its of little value and dropped in py3.

https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecycle.py#newcode1331
juju/unit/tests/test_lifecycle.py:1331: for i in xrange(1, 5):
ditto re xrange

https://codereview.appspot.com/6131061/

« Back to merge proposal