Merge lp:~jillrouleau/charms/trusty/percona-cluster/add-backup-action into lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next

[Jill Rouleau]

Add actions for full and incremental backups.

[Jorge Niedbalski (niedbalski)]

LGTM

review: Approve

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #8934 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8934/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #9712 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9712/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #6335 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6335/

[Billy Olsen (billy-olsen)]

Jill, thanks for the submission! Some minor comments included inline.

review: Needs Fixing

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #10472 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10472/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #9663 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9663/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #6615 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6615/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #14821 percona-cluster-next for jillrouleau mp270612
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/14821/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #15879 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/15879/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #8389 percona-cluster-next for jillrouleau mp270612
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8389/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #16580 percona-cluster-next for jillrouleau mp270612
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16580/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #8505 percona-cluster-next for jillrouleau mp270612
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14408041/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8505/

[James Page (james-page)]

Again sorry for the lag - you action looks great, but your branch needs a rebase/retest before we can land it.

Please set back to 'Needs review' once that is done.

Thanks!

review: Needs Fixing

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #1168 percona-cluster-next for jillrouleau mp287117
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1168/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #1410 percona-cluster-next for jillrouleau mp287117
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1410/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #520 percona-cluster-next for jillrouleau mp287117
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15195383/
Build: http://10.245.162.36:8080/job/charm_amulet_test/520/

[Billy Olsen (billy-olsen)]

#recheck

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #1227 percona-cluster-next for jillrouleau mp287117
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1227/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #1473 percona-cluster-next for jillrouleau mp287117
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1473/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #527 percona-cluster-next for jillrouleau mp287117
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/527/

[James Page (james-page)]

Migrated over to git/gerrit:

https://review.openstack.org/288342

Unmerged revisions

78. By Jill Rouleau on 2016-02-24

Resync to /next

77. By Jill Rouleau on 2016-01-15

Resync to /next, merge backup.py into new actions.py

76. By Jill Rouleau on 2015-12-23

swapping bash-bashed backup action for a python one

75. By Jill Rouleau on 2015-09-22

correcting action to correctly set fail status, handle errors more gracefully

74. By Jill Rouleau on 2015-09-09

remove extraneous symlink

73. By Jill Rouleau on 2015-09-09

add backup actions

=== modified file 'actions.yaml'
--- actions.yaml	2015-08-06 13:45:33 +0000
+++ actions.yaml	2016-02-25 00:06:27 +0000
@@ -1,4 +1,20 @@
 pause:
   description: Pause the MySQL service.
 resume:
-  description: Resume the MySQL service.
\ No newline at end of file
+  description: Resume the MySQL service.
+backup:
+  description: Full database backup
+  params:
+    basedir:
+      type: string
+      default: "/opt/backups/mysql"
+      description: The base directory for backups
+    compress:
+      type: boolean
+      default: false
+      description: Whether or not to compress the backup
+    incremental:
+      type: boolean
+      default: false
+      description: Make an incremental database backup
+

=== modified file 'actions/actions.py'
--- actions/actions.py	2015-10-10 16:19:59 +0000
+++ actions/actions.py	2016-02-25 00:06:27 +0000
@@ -2,12 +2,21 @@
 
 import os
 import sys
+import subprocess
+import traceback
+from time import gmtime, strftime
 
 from charmhelpers.core.host import service_pause, service_resume
-from charmhelpers.core.hookenv import action_fail, status_set
+from charmhelpers.core.hookenv import (
+    action_get,
+    action_set,
+    action_fail,
+    status_set,
+    config,
+)
+
 from percona_utils import assess_status
 
-
 MYSQL_SERVICE = "mysql"
 
 
@@ -32,9 +41,45 @@
     assess_status()
 
 
+def backup():
+    basedir = (action_get("basedir")).lower()
+    compress = (action_get("compress"))
+    incremental = (action_get("incremental"))
+    sstpw = config("sst-password")
+    optionlist = []
+
+    # innobackupex will not create recursive dirs that do not already exist,
+    # so help it along
+    if not os.path.exists(basedir):
+        os.makedirs(basedir)
+
+    # Build a list of options to pass to innobackupex
+    if compress is "true":
+        optionlist.append("--compress")
+
+    if incremental is "true":
+        optionlist.append("--incremental")
+
+    try:
+        subprocess.check_call(
+            ['innobackupex', '--compact', '--galera-info', '--rsync',
+             basedir, '--user=sstuser', '--password=' + sstpw] + optionlist)
+        action_set({
+            'time-completed': (strftime("%Y-%m-%d %H:%M:%S", gmtime())),
+            'outcome': 'Success'}
+        )
+    except subprocess.CalledProcessError as e:
+        action_set({
+            'time-completed': (strftime("%Y-%m-%d %H:%M:%S", gmtime())),
+            'output': e.output,
+            'return-code': e.returncode,
+            'traceback': traceback.format_exc()})
+        action_fail("innobackupex failed, you should log on to the unit"
+                    "and check the status of the database")
+
 # A dictionary of all the defined actions to callables (which take
 # parsed arguments).
-ACTIONS = {"pause": pause, "resume": resume}
+ACTIONS = {"pause": pause, "resume": resume, "backup": backup}
 
 
 def main(args):

=== added symlink 'actions/backup'
=== target is u'actions.py'