Merge lp:~jillrouleau/charms/trusty/mysql/raise-max-conns-lp1382386 into lp:charms/trusty/mysql

Proposed by Jill Rouleau
Status: Needs review
Proposed branch: lp:~jillrouleau/charms/trusty/mysql/raise-max-conns-lp1382386
Merge into: lp:charms/trusty/mysql
Diff against target: 31 lines (+6/-1) (has conflicts)
2 files modified
config.yaml (+1/-1)
metadata.yaml (+5/-0)
Text conflict in metadata.yaml
To merge this branch: bzr merge lp:~jillrouleau/charms/trusty/mysql/raise-max-conns-lp1382386
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing
Cory Johns (community) Needs Resubmitting
Review via email: mp+303638@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3433 mysql for jillrouleau mp303638
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/3433/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #2480 mysql for jillrouleau mp303638
    UNIT OK: passed

UNIT Results not found.
Build: http://10.245.162.36:8080/job/charm_unit_test/2480/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #844 mysql for jillrouleau mp303638
    AMULET OK: passed

AMULET Results not found.
Build: http://10.245.162.36:8080/job/charm_amulet_test/844/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #7 mysql for jillrouleau mp303638
    UNIT OK: passed

UNIT Results not found.
Build: http://10.245.162.208:8080/job/charm_unit_test/7/

Revision history for this message
Cory Johns (johnsca) wrote :

From the Contribute section of https://jujucharms.com/mysql/, it seems that the mysql charm now lives in https://github.com/marcoceppi/charm-mysql and changes should be submitted as PRs against that.

It also seems that this has a merge conflict, but otherwise the change seems reasonable.

review: Needs Resubmitting
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5413/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/5306/

review: Needs Fixing (automated testing)

Unmerged revisions

130. By Jill Rouleau

Change max-connections default to 500, for lp:1382386

129. By Tim Van Steenburgh

[niedbalski] Trusty to precise <-> syncup

128. By Tim Van Steenburgh

[jorge] Update to tags

127. By Marco Ceppi

[aisrael] Fix charm proof warnings and lint errors so that the charm will pass automated testing.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2015-12-30 02:20:40 +0000
3+++ config.yaml 2016-08-23 01:20:06 +0000
4@@ -24,7 +24,7 @@
5 type: int
6 description: Override the computed version from dataset-size. Still works if query-cache-type is "OFF" since sessions can override the cache type setting on their own.
7 max-connections:
8- default: -1
9+ default: 500
10 type: int
11 description: Maximum connections to allow. -1 means use the server's compiled in default.
12 wait-timeout:
13
14=== modified file 'metadata.yaml'
15--- metadata.yaml 2015-07-01 20:47:28 +0000
16+++ metadata.yaml 2016-08-23 01:20:06 +0000
17@@ -6,9 +6,14 @@
18 server. SQL (Structured Query Language) is the most popular database query
19 language in the world. The main goals of MySQL are speed, robustness and
20 ease of use.
21+<<<<<<< TREE
22 tags:
23 - databases
24 - openstack
25+=======
26+tags:
27+ - database
28+>>>>>>> MERGE-SOURCE
29 provides:
30 db:
31 interface: mysql

Subscribers

People subscribed via source and target branches

to all changes: