Merge lp:~jibel/ubuntu/trusty/adduser/LP1246331_enable_dep8 into lp:ubuntu/trusty/adduser

Proposed by Jean-Baptiste Lallement
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~jibel/ubuntu/trusty/adduser/LP1246331_enable_dep8
Merge into: lp:ubuntu/trusty/adduser
Diff against target: 44 lines (+15/-0)
4 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
debian/tests/adduser (+5/-0)
debian/tests/control (+3/-0)
To merge this branch: bzr merge lp:~jibel/ubuntu/trusty/adduser/LP1246331_enable_dep8
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+193249@code.launchpad.net

Description of the change

* Enable support for autopkgtest (LP:#1246331)

This patch add DEP8 support to run the existing testsuite with autopkgtest.
The test has no dependency because all the components to make adduser run should
be part of the core image.
The restriction allow-stderr is set because 'chage' prints messages to stderr
when tests run with shadow off.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I made a few minor changes (dropping Depends:, and adding a comment to control about "allow-stderr"). For forwarding to Debian you can just grab http://launchpadlibrarian.net/156041145/adduser_3.113%2Bnmu3ubuntu2_3.113%2Bnmu3ubuntu3.diff.gz ?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-06-07 11:24:08 +0000
3+++ debian/changelog 2013-10-30 14:08:47 +0000
4@@ -1,3 +1,9 @@
5+adduser (3.113+nmu3ubuntu3) trusty; urgency=low
6+
7+ * Enable autopkgtests (LP: #1246331)
8+
9+ -- Jean-Baptiste Lallement <jean-baptiste.lallement@canonical.com> Wed, 30 Oct 2013 14:51:16 +0100
10+
11 adduser (3.113+nmu3ubuntu2) saucy; urgency=low
12
13 * Move ecryptfs-utils from recommends, to suggests. (LP: #1188108)
14
15=== modified file 'debian/control'
16--- debian/control 2013-06-07 11:24:08 +0000
17+++ debian/control 2013-10-30 14:08:47 +0000
18@@ -10,6 +10,7 @@
19 Vcs-Svn: svn://svn.debian.org/adduser/
20 Vcs-Browser: http://svn.debian.org/wsvn/adduser/
21 Homepage: http://alioth.debian.org/projects/adduser/
22+XS-Testsuite: autopkgtest
23
24 Package: adduser
25 Architecture: all
26
27=== added directory 'debian/tests'
28=== added file 'debian/tests/adduser'
29--- debian/tests/adduser 1970-01-01 00:00:00 +0000
30+++ debian/tests/adduser 2013-10-30 14:08:47 +0000
31@@ -0,0 +1,5 @@
32+#!/bin/sh
33+set -eu
34+
35+cd testsuite
36+./runsuite.sh
37
38=== added file 'debian/tests/control'
39--- debian/tests/control 1970-01-01 00:00:00 +0000
40+++ debian/tests/control 2013-10-30 14:08:47 +0000
41@@ -0,0 +1,3 @@
42+Tests: adduser
43+Depends:
44+Restrictions: needs-root allow-stderr

Subscribers

People subscribed via source and target branches