Merge lp:~jibel/ubuntu/raring/software-properties/lp-1153989 into lp:ubuntu/raring/software-properties

Proposed by Jean-Baptiste Lallement
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~jibel/ubuntu/raring/software-properties/lp-1153989
Merge into: lp:ubuntu/raring/software-properties
Diff against target: 20 lines (+4/-3)
2 files modified
debian/tests/control (+3/-1)
debian/tests/run-tests (+1/-2)
To merge this branch: bzr merge lp:~jibel/ubuntu/raring/software-properties/lp-1153989
Reviewer Review Type Date Requested Status
Colin Watson Disapprove
Review via email: mp+152876@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

This branch fixes autopkgtests. It uses setup.py instead of make to run the tests which has been dropped in software-properties (0.92.14)

The following dep8 test dependencies have also been add:
python-distutils-extra
python-setuptools
python3-distutils-extra
python3-setuptools

Revision history for this message
Colin Watson (cjwatson) wrote :

Sorry, I fixed this independently before noticing your branch. I think my fix is a bit better, though, as it runs the tests under both Python 2 and 3.

review: Disapprove

Unmerged revisions

115. By Jean-Baptiste Lallement

debian/tests/run-tests: Use setup.py instead of make to run the tests and adds required test dependencies (LP: #1153989)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/tests/control'
2--- debian/tests/control 2012-10-29 13:51:14 +0000
3+++ debian/tests/control 2013-03-12 10:18:16 +0000
4@@ -1,2 +1,4 @@
5 Tests: run-tests
6-Depends: @, xvfb, python-dbus, python-pycurl, python3-pycurl, python-mock, python3-mock
7+Depends: @, xvfb, python-dbus, python-pycurl, python3-pycurl, python-mock,
8+ python3-mock, python-setuptools, python3-setuptools,
9+ python-distutils-extra, python3-distutils-extra
10
11=== modified file 'debian/tests/run-tests'
12--- debian/tests/run-tests 2012-09-10 09:51:29 +0000
13+++ debian/tests/run-tests 2013-03-12 10:18:16 +0000
14@@ -2,6 +2,5 @@
15
16 set -e
17
18-cd tests
19-xvfb-run make
20+xvfb-run ./setup.py test
21

Subscribers

People subscribed via source and target branches