Code review comment for lp:~jibel/ubuntu/bionic/apport/lp1582950_2_ubiquity_hook

Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks for working on this. I believe isinstance() is preferred to using type().

https://docs.python.org/3/library/functions.html#type

Did you test this with both scenarios outlined in the bug?

review: Needs Fixing

« Back to merge proposal