Merge lp:~jibel/ubuntu-cdimage/support_ubuntu_subproject into lp:ubuntu-cdimage
Proposed by
Jean-Baptiste Lallement
Status: | Rejected |
---|---|
Rejected by: | Steve Langasek |
Proposed branch: | lp:~jibel/ubuntu-cdimage/support_ubuntu_subproject |
Merge into: | lp:ubuntu-cdimage |
Diff against target: |
12 lines (+2/-1) 1 file modified
lib/cdimage/tree.py (+2/-1) |
To merge this branch: | bzr merge lp:~jibel/ubuntu-cdimage/support_ubuntu_subproject |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak | Disapprove | ||
Review via email: mp+365598@code.launchpad.net |
Description of the change
Fixed publication of subproject for Ubuntu Desktop images
For ubuntu desktop images publish subproject to
ubuntu/
Currently when a canary (subproject of Ubuntu) image is built then published,
the publication creates an empty directory under ubuntu/daily-live.
To post a comment you must log in.
Unmerged revisions
- 1799. By Jean-Baptiste Lallement
-
tree.py: strip trailing slash when there is a subproject
- 1798. By Jean-Baptiste Lallement
-
Support subproject publication directory for Ubuntu
For Ubuntu Desktop images, when a subproject is defined, publish the image to
cdimage.u.c under ubuntu/<subproject/ <image_ type>/< timestamp>
Thanks for the merge request! I just took a quick look at it for now and I need to still think about all the consequences of the change. For now one thing that needs fixing: tests. There's one test failing right now, might need some tweaking.
To run the tests, just execute ./run-tests .
Let me get back to you with a final review tomorrow