Merge lp:~jibel/synaptic/bug.130289 into lp:synaptic

Proposed by Jean-Baptiste Lallement
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jibel/synaptic/bug.130289
Merge into: lp:synaptic
Diff against target: 27 lines (+6/-4)
1 file modified
gtk/rgpreferenceswindow.cc (+6/-4)
To merge this branch: bzr merge lp:~jibel/synaptic/bug.130289
Reviewer Review Type Date Requested Status
synaptic-developers Pending
Review via email: mp+22547@code.launchpad.net

Description of the change

Resubmitting since I inadvertently removed the wrong branch.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk/rgpreferenceswindow.cc'
2--- gtk/rgpreferenceswindow.cc 2009-01-07 09:51:51 +0000
3+++ gtk/rgpreferenceswindow.cc 2010-03-31 16:14:25 +0000
4@@ -26,6 +26,7 @@
5
6 #include <apt-pkg/error.h>
7 #include <apt-pkg/configuration.h>
8+#include <apt-pkg/strutl.h>
9 #include <gtk/gtk.h>
10 #include <cassert>
11 #include <cstring>
12@@ -160,10 +161,11 @@
13 g_free(s);
14 }
15 // setup the proxy
16- if(!httpUser.empty() && !httpPass.empty()) {
17- s = g_strdup_printf("http://%s:%s@%s:%i/",
18- httpUser.c_str(), httpPass.c_str(),
19- http.c_str(), httpPort);
20+ if(!httpUser.empty() && !httpPass.empty()) {
21+ s = g_strdup_printf("http://%s:%s@%s:%i/",
22+ QuoteString(httpUser, "@%:/").c_str(),
23+ QuoteString(httpPass, "@%:/").c_str(),
24+ http.c_str(), httpPort);
25 _config->Set("Acquire::http::Proxy", s);
26 g_free(s);
27 }

Subscribers

People subscribed via source and target branches

to status/vote changes: