Code review comment for ~jibel/curtin/+git/add-layer-images-support:master
Revision history for this message
| Jean-Baptiste Lallement (jibel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
@Chad, thanks for review.
We've updated the branch with most of your proposals:
- The download code if the layers of a stack image have been moved to its function.
- We've added retries and retry_delay argument to the url_helper.download and set it to 3 by default in existing download functions.
- There is now a test to cover download errors.
- unittests have been added to cover the new download helper functionality and verified the coverage.
Note that tests of the extract module have not been updated, as covering the public commands extract API already covers this submodule, and there isn’t much value in adding separated unittests.