Code review comment for ~jibel/curtin/+git/add-layer-images-support:master

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for the review

About 1 and 2, this is documented in, where do you want to capture these elements? Or is there something to clarify in the documentation?

Ok, to add more logs but we already log the list of image detected and if an error occurs, the image that caused this error. What else would you like to log?
We could add more debug output in _get_image_path but since it's recursive it would be excessively verbose.

About your last point, the goal is to provide to curtin a single leaf filesystem in its yaml config file and it mounts the entire hierarchy of filesystems without any knowledge extra in the caller of curtin. It's very similar to the existing fsimage but for multilayer filesystems. This is implemented for the desktop images and is a pre-requisite for the new desktop installer which will rely on curtin.

For instance for the desktop the filesystems will be minimal, standard, and languages packs for minimal and standard, depending on the choice of the user (minimal vs normal and the language) We'll point curtin to the right squashfs containing the language pack and it will install the corresponding squashfses for the entire hierarchy. This has been tested successfully with this patch.

« Back to merge proposal