Code review comment for ~jibel/curtin/+git/add-layer-images-support:master

Revision history for this message
Scott Moser (smoser) wrote :

https://code.launchpad.net/~smoser/curtin/+git/curtin/+merge/360950
I put some changes there that i think make sense. As of
 c65cd19723140ca9a4cebc50a60fa6fb8be7ff1e
you should be able to just pull.

2 other comments:
a.) it sure would be nice to have *some* test of extract_root_layered_fsimage.
b.) ultimately we're going to need some vmtest here. Thats our only way to do integration test and actually ensure that this doesnt work.

I dont' want to push on 'b' right now, but we do need it for sure.

« Back to merge proposal