snappy-hwe-snaps

Merge ~jhodapp/snappy-hwe-snaps/+git/examples:master into ~snappy-hwe-team/snappy-hwe-snaps/+git/examples:master

  1. Git
  2. lp:~jhodapp/snappy-hwe-snaps/+git/examples
  3. master
  4. Merge into master
Proposed by Jim Hodapp
Status: Merged
Approved by: Simon Fels
Approved revision: 7e3181489cc00785a8ff283e338a4636d32f912c
Merged at revision: 6a6a9e037513d834bb736e6675a86dd840b88933
Proposed branch: ~jhodapp/snappy-hwe-snaps/+git/examples:master
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/examples:master
Diff against target: 12 lines (+1/-0)
1 file modified
pulseaudio-example-clients/snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Simon Fels Approve
Konrad Zapałowicz (community) code Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+299845@code.launchpad.net

Commit message

Make sure to include libpulsecommon-8.0.so

Description of the change

Make sure to include libpulsecommon-8.0.so

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) :
review: Needs Information
Revision history for this message
Jim Hodapp (jhodapp) :
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Addressed comment.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:7e3181489cc00785a8ff283e338a4636d32f912c
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/109/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/10/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/109/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:7e3181489cc00785a8ff283e338a4636d32f912c
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/110/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/11/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/110/rebuild

review: Approve (continuous-integration)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

Ack

review: Approve (code)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/pulseaudio-example-clients/snapcraft.yaml b/pulseaudio-example-clients/snapcraft.yaml
2index b527c6f..27ab035 100644
3--- a/pulseaudio-example-clients/snapcraft.yaml
4+++ b/pulseaudio-example-clients/snapcraft.yaml
5@@ -41,6 +41,7 @@ parts:
6 snap:
7 - usr/bin/paplay
8 - usr/bin/pactl
9+ - usr/lib/*/pulseaudio/libpulsecommon-8.0.so*
10 - usr/share/sounds/alsa/Noise.wav
11 - usr/lib/*/libpulse.so*
12 - usr/lib/*/libsndfile.so*

Subscribers

People subscribed via source and target branches

to all changes: