Merge lp:~jhodapp/qtvideo-node/nexus7-video-fix into lp:qtvideo-node

Proposed by Jim Hodapp
Status: Merged
Approved by: Günter Schwann
Approved revision: 32
Merged at revision: 25
Proposed branch: lp:~jhodapp/qtvideo-node/nexus7-video-fix
Merge into: lp:qtvideo-node
Diff against target: 11 lines (+0/-1)
1 file modified
src/shadervideoshader.cpp (+0/-1)
To merge this branch: bzr merge lp:~jhodapp/qtvideo-node/nexus7-video-fix
Reviewer Review Type Date Requested Status
Günter Schwann (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+153914@code.launchpad.net

Commit message

Fix video playback so that it works on the Nexus 7 device. Audio still does not work. The GL_OES_EGL_image_external OpenGL extension should never have been included in the first place for the shader.

Description of the change

Fix video playback so that it works on the Nexus 7 device. Audio still does not work. The GL_OES_EGL_image_external OpenGL extension should never have been included in the first place for the shader.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Günter Schwann (schwann) wrote :

Camera and media player work fine on Nexus 10

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/shadervideoshader.cpp'
2--- src/shadervideoshader.cpp 2013-02-12 14:04:56 +0000
3+++ src/shadervideoshader.cpp 2013-03-18 19:19:22 +0000
4@@ -56,7 +56,6 @@
5 const char *ShaderVideoShader::vertexShader() const
6 {
7 const char *shader =
8- "#extension GL_OES_EGL_image_external : require \n"
9 "uniform highp mat4 qt_Matrix; \n"
10 "attribute highp vec4 qt_VertexPosition; \n"
11 "attribute highp vec2 qt_VertexTexCoord; \n"

Subscribers

People subscribed via source and target branches