Merge lp:~jhodapp/qtubuntu-media/fix-1381930 into lp:qtubuntu-media

Proposed by Jim Hodapp
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 53
Merged at revision: 57
Proposed branch: lp:~jhodapp/qtubuntu-media/fix-1381930
Merge into: lp:qtubuntu-media
Diff against target: 19 lines (+8/-1)
1 file modified
src/aal/aalmediaplayercontrol.cpp (+8/-1)
To merge this branch: bzr merge lp:~jhodapp/qtubuntu-media/fix-1381930
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Michał Sawicz code Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+240327@code.launchpad.net

Commit message

Fix URI encoding issue related to playing remote URIs like from 7digital

Description of the change

Fix URI encoding issue related to playing remote URIs like from 7digital

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Code looks good, please top-ack after testing.

We could use unit tests! ;)

review: Approve (code)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/aal/aalmediaplayercontrol.cpp'
2--- src/aal/aalmediaplayercontrol.cpp 2014-09-02 23:32:08 +0000
3+++ src/aal/aalmediaplayercontrol.cpp 2014-10-31 19:45:41 +0000
4@@ -291,7 +291,14 @@
5 if (media.isNull())
6 return QUrl();
7
8- return QUrl::fromPercentEncoding(media.canonicalUrl().toString().toUtf8());
9+ if (media.canonicalUrl().isLocalFile()) {
10+ qDebug() << "Local file URI: " << QUrl::fromPercentEncoding(media.canonicalUrl().toString().toUtf8());
11+ return QUrl::fromPercentEncoding(media.canonicalUrl().toString().toUtf8());
12+ }
13+ else {
14+ qDebug() << "Remote stream URI: " << QUrl::fromEncoded(media.canonicalUrl().toString().toUtf8());
15+ return QUrl::fromEncoded(media.canonicalUrl().toString().toUtf8());
16+ }
17 }
18
19 void AalMediaPlayerControl::setMediaStatus(QMediaPlayer::MediaStatus status)

Subscribers

People subscribed via source and target branches