Merge lp:~jhodapp/qtubuntu-media-signals/orientation into lp:qtubuntu-media-signals

Proposed by Jim Hodapp
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 16
Merged at revision: 16
Proposed branch: lp:~jhodapp/qtubuntu-media-signals/orientation
Merge into: lp:qtubuntu-media-signals
Diff against target: 62 lines (+22/-2)
2 files modified
src/qtubuntu_media_signals.cpp (+2/-1)
src/qtubuntu_media_signals.h (+20/-1)
To merge this branch: bzr merge lp:~jhodapp/qtubuntu-media-signals/orientation
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+238208@code.launchpad.net

Commit message

Add a signal that sets the desired video orientation and height/width, for use in qtvideo-node

Description of the change

Add a signal that sets the desired video orientation and height/width, for use in qtvideo-node

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qtubuntu_media_signals.cpp'
2--- src/qtubuntu_media_signals.cpp 2013-03-08 20:12:31 +0000
3+++ src/qtubuntu_media_signals.cpp 2014-10-13 19:36:31 +0000
4@@ -1,5 +1,5 @@
5 /*
6- * Copyright (C) 2013 Canonical, Ltd.
7+ * Copyright (C) 2013-2014 Canonical, Ltd.
8 *
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU Lesser General Public License as published by
11@@ -24,6 +24,7 @@
12 SharedSignal::SharedSignal(QObject *parent)
13 : QObject(parent)
14 {
15+ qRegisterMetaType<SharedSignal::Orientation>("SharedSignal::Orientation");
16 }
17
18 SharedSignal* SharedSignal::instance()
19
20=== modified file 'src/qtubuntu_media_signals.h'
21--- src/qtubuntu_media_signals.h 2014-03-17 15:34:29 +0000
22+++ src/qtubuntu_media_signals.h 2014-10-13 19:36:31 +0000
23@@ -1,5 +1,5 @@
24 /*
25- * Copyright (C) 2013 Canonical, Ltd.
26+ * Copyright (C) 2013-2014 Canonical, Ltd.
27 *
28 * This program is free software; you can redistribute it and/or modify
29 * it under the terms of the GNU Lesser General Public License as published by
30@@ -28,6 +28,18 @@
31 {
32 Q_OBJECT
33 public:
34+
35+ /** This needs to stay in sync with the same definition in media-hub
36+ * include/core/media/player.h
37+ */
38+ enum Orientation
39+ {
40+ rotate0,
41+ rotate90,
42+ rotate180,
43+ rotate270
44+ };
45+
46 static SharedSignal* instance();
47
48 Q_SIGNALS:
49@@ -39,6 +51,13 @@
50 * has been successfully passed to it and set.
51 */
52 void glConsumerSet();
53+ /** Thrown by AalMediaPlayerService to indicate to qtvideo-node
54+ * which rotation transformation matrix needs to be applied to
55+ * each video frame for rendering.
56+ * @param orientaiton rotate0, rotate90, rotate180, rotate270
57+ * @param size width/height of a video frame
58+ */
59+ void setOrientation(const SharedSignal::Orientation& orientation, const QSize &size);
60 /** Thrown by AalVideoRendererControl to signal set the snapshot size.
61 */
62 void setSnapshotSize(const QSize &size);

Subscribers

People subscribed via source and target branches