Juju Charms Collection
wildfly package

Code review comment for lp:~jhasaurabh/charms/precise/wildfly/trunk

  1. Precise Pangolin (12.04)
  2. trunk
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

Saurabh,

Thank you for this fix to the WildFly charm! The change looks good and works in my testing as well.

Out of curiosity, though, why did you change the name of the backup file? It seems that just changing the mv command to cp would have been sufficient and the smaller diff would have been a bit easier to review.

Regardless, the change is good and gets my +1. Thanks again for this fix!

review: Approve

« Back to merge proposal