Merge ~jgrimm/ubuntu/+source/libqb:merge-zesty-1.0.1-1ubuntu1 into ~usd-import-team/ubuntu/+source/libqb:debian/sid

Proposed by Jon Grimm on 2017-02-16
Status: Merged
Merge reported by: Nish Aravamudan
Merged at revision: not available
Proposed branch: ~jgrimm/ubuntu/+source/libqb:merge-zesty-1.0.1-1ubuntu1
Merge into: ~usd-import-team/ubuntu/+source/libqb:debian/sid
Diff against target: 221 lines (+136/-1)
5 files modified
debian/changelog (+85/-0)
debian/control (+2/-1)
debian/patches/aarch64_no_coarse_clock.patch (+27/-0)
debian/patches/series (+4/-0)
debian/patches/ubuntu_disable_tests.patch (+18/-0)
Reviewer Review Type Date Requested Status
Nish Aravamudan 2017-02-16 Approve on 2017-02-16
Review via email: mp+317540@code.launchpad.net

Description of the Change

1) I added a reference to the kernel bug that the aarch workaround patch is for.
2) I've added a libqb task to same bug, in hopes that when the kernel team verifies that the kernel side is fixed we can drop this aarch patch.
3) I reworked the ubuntu_disable_tests.patch to not disable rb or ipc test as they seem to work for me after consult with rbasak. Worst case we re-enable if turn out flaky still in the real builders.

To post a comment you must log in.
Nish Aravamudan (nacc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index d727d09..357c677 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,18 @@
6+libqb (1.0.1-1ubuntu1) zesty; urgency=medium
7+
8+ * Merge from Debian unstable. Remaining changes:
9+ - debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
10+ cause the package to FTBFS. Modified patch to reenable rb and ipc
11+ tests as seem to work now.
12+ - debian/patches/aarch64_no_coarse_clock.patch: Avoid
13+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug (LP: 1239109)
14+ * Dropping unneeded refreshes on debian patches from last upload:
15+ - debian/patches/hurd-support.patch
16+ - debian/patches/low-fixed-Spelling-error-of-failure-in-qbhdb.h.patch
17+ - debian/patches/ubuntu_disable_tests.patch
18+
19+ -- Jon Grimm <jon.grimm@canonical.com> Thu, 16 Feb 2017 12:36:50 -0600
20+
21 libqb (1.0.1-1) unstable; urgency=medium
22
23 [ Christoph Berg ]
24@@ -15,6 +30,16 @@ libqb (1.0.1-1) unstable; urgency=medium
25
26 -- Ferenc Wágner <wferi@debian.org> Wed, 07 Dec 2016 14:55:06 +0100
27
28+libqb (1.0-1ubuntu1) yakkety; urgency=low
29+
30+ * Merge from Debian unstable. Remaining changes:
31+ - debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
32+ cause the package to FTBFS.
33+ - debian/patches/aarch64_no_coarse_clock.patch: Avoid
34+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug.
35+
36+ -- James Page <james.page@ubuntu.com> Mon, 27 Jun 2016 11:55:44 +0100
37+
38 libqb (1.0-1) unstable; urgency=medium
39
40 [ Arturo Borrero Gonzalez ]
41@@ -53,6 +78,16 @@ libqb (1.0-1) unstable; urgency=medium
42
43 -- Ferenc Wágner <wferi@niif.hu> Wed, 22 Jun 2016 09:48:05 +0200
44
45+libqb (0.17.2.real-6ubuntu1) xenial; urgency=low
46+
47+ * Merge from Debian unstable. Remaining changes:
48+ - debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
49+ cause the package to FTBFS.
50+ - debian/patches/aarch64_no_coarse_clock.patch: Avoid
51+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug.
52+
53+ -- James Page <james.page@ubuntu.com> Wed, 02 Mar 2016 10:01:35 +0000
54+
55 libqb (0.17.2.real-6) unstable; urgency=medium
56
57 * Update hurd support patch to fix regression in sem_timedwait detection.
58@@ -67,6 +102,16 @@ libqb (0.17.2.real-5) unstable; urgency=medium
59
60 -- Christoph Berg <myon@debian.org> Fri, 19 Feb 2016 11:19:26 +0100
61
62+libqb (0.17.2.real-4ubuntu1) xenial; urgency=low
63+
64+ * Merge from Debian unstable. Remaining changes:
65+ - debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
66+ cause the package to FTBFS.
67+ - debian/patches/aarch64_no_coarse_clock.patch: Avoid
68+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug.
69+
70+ -- James Page <james.page@ubuntu.com> Mon, 04 Jan 2016 11:43:59 +0000
71+
72 libqb (0.17.2.real-4) unstable; urgency=medium
73
74 * Add debian/libqb0.symbols.ppc64 symlink.
75@@ -214,6 +259,16 @@ libqb (0.17.1-1) unstable; urgency=medium
76
77 -- Christoph Berg <christoph.berg@credativ.de> Wed, 06 May 2015 14:28:46 +0200
78
79+libqb (0.17.0-2ubuntu1) vivid; urgency=medium
80+
81+ * Resynchronise with Debian. Remaining changes:
82+ - debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
83+ cause the package to FTBFS.
84+ - debian/patches/aarch64_no_coarse_clock.patch: Avoid
85+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug.
86+
87+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 02 Dec 2014 16:35:37 +0000
88+
89 libqb (0.17.0-2) unstable; urgency=medium
90
91 * debian/patches/buildfix-dvossel-1.patch: Add an additional fix by dvossel
92@@ -243,6 +298,27 @@ libqb (0.16.0.real-1.1) unstable; urgency=medium
93
94 -- Anibal Monsalve Salazar <anibal@debian.org> Thu, 20 Feb 2014 07:21:30 +0000
95
96+libqb (0.16.0.real-1ubuntu3) trusty; urgency=medium
97+
98+ * debian/patches/ubuntu_disable_tests.patch: Remove dependency of
99+ resources.log on disabled tests.
100+
101+ -- Colin Watson <cjwatson@ubuntu.com> Tue, 17 Dec 2013 18:06:07 +0000
102+
103+libqb (0.16.0.real-1ubuntu2) saucy; urgency=low
104+
105+ * debian/patches/aarch64_no_coarse_clock.patch: Avoid
106+ CLOCK_REALTIME_COARSE on aarch64 due to a kernel bug.
107+
108+ -- William Grant <wgrant@ubuntu.com> Sat, 12 Oct 2013 19:07:55 +1100
109+
110+libqb (0.16.0.real-1ubuntu1) saucy; urgency=low
111+
112+ * Merge from Debian unstable. Remaining changes:
113+ - debian/patches/ubuntu_disable_tests.patch: Updated.
114+
115+ -- Andres Rodriguez <andreserl@ubuntu.com> Thu, 15 Aug 2013 11:38:09 -0400
116+
117 libqb (0.16.0.real-1) unstable; urgency=low
118
119 * New upload, this time with the "right" upstream .orig.tar.gz
120@@ -255,6 +331,14 @@ libqb (0.16.0-1) unstable; urgency=low
121
122 -- Martin Loschwitz <madkiss@debian.org> Thu, 01 Aug 2013 10:57:28 +0000
123
124+libqb (0.14.4-1ubuntu1) saucy; urgency=low
125+
126+ * Resync from debian experimental.
127+ * debian/patches/ubuntu_disable_tests.patch: Disable failing tests that
128+ cause the package to FTBFS.
129+
130+ -- Andres Rodriguez <andreserl@ubuntu.com> Mon, 22 Jul 2013 16:47:44 -0400
131+
132 libqb (0.14.4-1) experimental; urgency=low
133
134 * New upstream release
135@@ -291,3 +375,4 @@ libqb (0.11.1-1) unstable; urgency=low
136 * Initial release (Closes: #666504)
137
138 -- Martin Loschwitz <madkiss@debian.org> Sun, 01 Apr 2012 16:47:49 +0000
139+
140diff --git a/debian/control b/debian/control
141index ea8ada1..4c1eb85 100644
142--- a/debian/control
143+++ b/debian/control
144@@ -1,6 +1,7 @@
145 Source: libqb
146 Priority: optional
147-Maintainer: Debian HA Maintainers <debian-ha-maintainers@lists.alioth.debian.org>
148+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
149+XSBC-Original-Maintainer: Debian HA Maintainers <debian-ha-maintainers@lists.alioth.debian.org>
150 Uploaders:
151 Richard B Winters <rik@mmogp.com>,
152 Ferenc Wágner <wferi@debian.org>,
153diff --git a/debian/patches/aarch64_no_coarse_clock.patch b/debian/patches/aarch64_no_coarse_clock.patch
154new file mode 100644
155index 0000000..565a194
156--- /dev/null
157+++ b/debian/patches/aarch64_no_coarse_clock.patch
158@@ -0,0 +1,27 @@
159+From: William Grant <wgrant@ubuntu.com>
160+Description: Avoid CLOCK_REALTIME_COARSE on aarch64 to avoid a kernel bug.
161+ .
162+ __kernel_clock_gettime in the aarch64 VDSO is buggy in the
163+ CLOCK_{REALTIME,MONOTONIC}_COARSE cases, resulting in a SIGSEGV or
164+ SIGBUS when it attempts to return.
165+
166+--- a/lib/util.c
167++++ b/lib/util.c
168+@@ -153,7 +153,7 @@ qb_util_nano_from_epoch_get(void)
169+ {
170+ uint64_t nano_monotonic;
171+ struct timespec ts;
172+-#ifdef CLOCK_REALTIME_COARSE
173++#if defined(CLOCK_REALTIME_COARSE) && !defined(__aarch64__)
174+ clock_gettime(CLOCK_REALTIME_COARSE, &ts);
175+ #else
176+ clock_gettime(CLOCK_REALTIME, &ts);
177+@@ -185,7 +185,7 @@ qb_util_nano_monotonic_hz(void)
178+ void
179+ qb_util_timespec_from_epoch_get(struct timespec *ts)
180+ {
181+-#ifdef CLOCK_REALTIME_COARSE
182++#if defined(CLOCK_REALTIME_COARSE) && !defined(__aarch64__)
183+ clock_gettime(CLOCK_REALTIME_COARSE, ts);
184+ #else
185+ clock_gettime(CLOCK_REALTIME, ts);
186diff --git a/debian/patches/series b/debian/patches/series
187index 52f6355..7ab5083 100644
188--- a/debian/patches/series
189+++ b/debian/patches/series
190@@ -9,3 +9,7 @@ Restrict-ldl-to-where-it-s-actually-needed.patch
191 Restrict-pthreads-to-where-it-s-actually-needed.patch
192 Restrict-socket-lib-to-where-it-s-actually-needed.patch
193 Restrict-nsl-lib-to-where-it-s-actually-needed.patch
194+
195+# Ubuntu
196+ubuntu_disable_tests.patch
197+aarch64_no_coarse_clock.patch
198diff --git a/debian/patches/ubuntu_disable_tests.patch b/debian/patches/ubuntu_disable_tests.patch
199new file mode 100644
200index 0000000..a512b1c
201--- /dev/null
202+++ b/debian/patches/ubuntu_disable_tests.patch
203@@ -0,0 +1,18 @@
204+--- a/tests/Makefile.am
205++++ b/tests/Makefile.am
206+@@ -103,12 +103,12 @@ if HAVE_CHECK
207+ EXTRA_DIST += resources.test
208+ EXTRA_DIST += blackbox-segfault.sh
209+
210+-TESTS = array.test map.test rb.test log.test blackbox-segfault.sh loop.test ipc.test resources.test
211++TESTS = array.test map.test rb.test blackbox-segfault.sh loop.test ipc.test resources.test
212+
213+-resources.log: rb.log log.log ipc.log
214++resources.log: rb.log ipc.log
215+
216+ check_LTLIBRARIES =
217+-check_PROGRAMS = array.test map.test rb.test log.test loop.test ipc.test util.test crash_test_dummy file_change_bytes
218++check_PROGRAMS = array.test map.test rb.test loop.test ipc.test util.test crash_test_dummy file_change_bytes
219+ dist_check_SCRIPTS = resources.test blackbox-segfault.sh
220+
221+ if HAVE_SLOW_TESTS

Subscribers

People subscribed via source and target branches