Merge lp:~jgottula/python-v4l2/fix-for-bug-1664158 into lp:python-v4l2

Proposed by Justin Gottula
Status: Needs review
Proposed branch: lp:~jgottula/python-v4l2/fix-for-bug-1664158
Merge into: lp:python-v4l2
Diff against target: 21 lines (+2/-2)
1 file modified
v4l2.py (+2/-2)
To merge this branch: bzr merge lp:~jgottula/python-v4l2/fix-for-bug-1664158
Reviewer Review Type Date Requested Status
python-v4l2 developers Pending
Review via email: mp+340558@code.launchpad.net

Description of the change

Fix for Python 3 incompatibility related to `range` changes. Bug #1664158.

Would really like this to get merged, and for the package on PyPi to get updated accordingly (https://pypi.python.org/pypi/v4l2), because for the time being, anyone on the planet using any operating system who uses `pip` to install some Python package that happens to have `v4l2` as one of its dependencies will automatically have the current (Python-3-incompatible) version of the `v4l2` module downloaded and installed on their system, which in turn causes things not to work properly.

To post a comment you must log in.

Unmerged revisions

31. By Justin Gottula

Fixed #1664158

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'v4l2.py'
2--- v4l2.py 2010-07-22 01:07:58 +0000
3+++ v4l2.py 2018-03-03 02:17:34 +0000
4@@ -194,7 +194,7 @@
5 V4L2_BUF_TYPE_SLICED_VBI_OUTPUT,
6 V4L2_BUF_TYPE_VIDEO_OUTPUT_OVERLAY,
7 V4L2_BUF_TYPE_PRIVATE,
8-) = range(1, 9) + [0x80]
9+) = list(range(1, 9)) + [0x80]
10
11
12 v4l2_ctrl_type = enum
13@@ -245,7 +245,7 @@
14 V4L2_PRIORITY_INTERACTIVE,
15 V4L2_PRIORITY_RECORD,
16 V4L2_PRIORITY_DEFAULT,
17-) = range(0, 4) + [2]
18+) = list(range(0, 4)) + [2]
19
20
21 class v4l2_rect(ctypes.Structure):

Subscribers

People subscribed via source and target branches