Sakura

Merge lp:~jfontan/sakura/urgent_focus into lp:~dabisu/sakura/sakura

  1. urgent_focus
  2. Merge into sakura
Proposed by Javi Fontan
Status: Merged
Approved by: David Gómez
Approved revision: 565
Merge reported by: David Gómez
Merged at revision: not available
Proposed branch: lp:~jfontan/sakura/urgent_focus
Merge into: lp:~dabisu/sakura/sakura
Diff against target: 10 lines (+1/-0)
1 file modified
src/sakura.c (+1/-0)
To merge this branch: bzr merge lp:~jfontan/sakura/urgent_focus
Reviewer Review Type Date Requested Status
David Gómez Approve
Review via email: mp+315638@code.launchpad.net

Description of the change

Fixes bug #1542585.

I've been able to test it in i3wm this way:

* Execute "sleep 5 && echo -ne \\a" and change focus to set the urgent hint
* Window changes color to indicate urgent flag
* Clean it focusing the window
* Restart i3wm
* Current version has urgent color again after i3wm restart, this change fixes that

To post a comment you must log in.
Revision history for this message
David Gómez (dabisu) wrote :

Thanks for the patch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/sakura.c'
2--- src/sakura.c 2017-01-08 17:21:54 +0000
3+++ src/sakura.c 2017-01-25 22:27:50 +0000
4@@ -1780,6 +1780,7 @@
5 sakura_set_colors();
6
7 }
8+ gtk_window_set_urgency_hint(GTK_WINDOW(sakura.main_window), FALSE);
9 return FALSE;
10 }
11

Subscribers

People subscribed via source and target branches