~jfguedez/juju-backup-all:bug/1951916

Branch merges

Propose for merging

Merged into juju-backup-all:master at revision fcf7c8fe40fee0b0015e455ecc8861286f1e8cef

BootStack Reviewers: Pending requested 2021-11-23

Diff: 131 lines (+16/-17)

5 files modified

jujubackupall/backup.py (+3/-3)
jujubackupall/cli.py (+2/-1)
jujubackupall/process.py (+1/-1)
tests/unit/test_backup.py (+9/-11)
tests/unit/test_process.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

a3592ba... by Jose Guedez on 2021-11-23

Refactor BackupProcessor.process_backups to return json

Closes-Bug: 1951916

c8ffbea... by Zachary Zehring on 2021-10-25

Add additional metadata to snapcraft.yaml

Reviewed-on: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/410458
Reviewed-by: James Troup <email address hidden>
Reviewed-by: Giuseppe Petralia <email address hidden>

2b59172... by Zachary Zehring on 2021-10-19

Add additional metadata to snapcraft.yaml

bc1d1fc... by Zachary Zehring on 2021-10-18

Update README with new Snap changes.

Reviewed-on: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/410406
Reviewed-by: James Troup <email address hidden>

6058d25... by Zachary Zehring on 2021-10-18

Update README with new Snap changes.

The tool is now a confined snap and available on the Snap Store. This
commit updates the README with:

- embedded Snap Store image link in Introduction
- additional section on how to install the charm
- removed --classic flag when installing the charm locally

65a2d9c... by Zachary Zehring on 2021-10-07

Add ability to pass timeout argument from cli.

Reviewed-on: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/409870
Reviewed-by: James Troup <email address hidden>

9fb3f29... by Zachary Zehring on 2021-10-07

Add ability to pass timeout argument from cli.

6e84b77... by Zachary Zehring on 2021-10-07

Implement timeout for long-running async calls.

Reviewed-on: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/409863
Reviewed-by: James Troup <email address hidden>

a6128f7... by Zachary Zehring on 2021-10-07

Implement timeout for long-running async calls.

A timeout mechanism is needed to running long async actions that can get stuck
such as controller backups, application backups via actions, etc.
Specifically, if an action gets "stuck" python-libjuju's wait() command will
wait indefinitely.

This commit introduces a run_with_timeout util for commands that can
potentially run forever. We also introduce JujuTimeoutError that will be
raised when the task takes too long to finish.

We're also adding a default timeout value of 10 mins which is hardcoded into
constants.py. This will inevitably be refactored into a configurable value.

af85b06... by Zachary Zehring on 2021-10-06

Catch generic Juju erors during app backup

Reviewed-on: https://code.launchpad.net/~zzehring/juju-backup-all/+git/juju-backup-all/+merge/409778
Reviewed-by: James Troup <email address hidden>