~jfguedez/charm-ubuntu-advantage:bug/1962335

Branch merges

Propose for merging

Merged into charm-ubuntu-advantage:master at revision 05a3802c0fa7c349544c5d29fe11175eb694ac65

Tom Haddon: Approve on 2022-03-08

Canonical IS Reviewers: Pending requested 2022-03-03

Diff: 1548 lines (+1363/-45)

4 files modified

lib/charms/operator_libs_linux/v0/apt.py (+1329/-0)
run_tests (+4/-3)
src/charm.py (+3/-13)
tests/test_charm.py (+27/-29)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

08fa05c... by Jose Guedez on 2022-03-02

Use the operator apt library to install/remove packages

The library used here comes from the following PR, since
a couple bugs were discovered while working on this change.
* https://github.com/canonical/operator-libs-linux/pull/41

Closes-Bug: 1962284
Closes-Bug: 1962335

34e7823... by Tom Haddon on 2022-02-25

Add charmcraft.yaml so we can build the charm using charmcraft

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/416087
Reviewed-by: Nick Moffitt <email address hidden>

b584b83... by Tom Haddon on 2022-02-25

Add charmcraft.yaml so we can build the charm using charmcraft

2ff56b6... by Jose Guedez on 2022-02-25

Add support for proxy settings from the model

Reviewed-on: https://code.launchpad.net/~jfguedez/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/415946
Reviewed-by: Tom Haddon <email address hidden>

e8265de... by Jose Guedez on 2022-02-23

Refactor proxy support

* apt already supports proxy via apt-http[s]-proxy variables
* add proxy configuration to the UA client
* only `add-apt-repository` needs environment variables
* update unit tests, and add an extra test to cover proxies

e1f54bb... by Jose Guedez on 2022-02-22

fix broken unit tests

493ac61... by Bartosz Woronicz on 2021-12-03

Add support for proxy settings from the model

Closes-Bug: 1944591

a0f3abf... by Tom Haddon on 2021-11-02

Update readme to use charmhub location

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/411170
Reviewed-by: Colin Misare <email address hidden>

f423771... by Tom Haddon on 2021-11-02

Update readme to use charmhub location

5d93cdb... by Colin Misare on 2021-05-06

Bug fix and improved logging

- Pinning to ops==1.1.0 until until https://github.com/canonical/operator/pull/520 is published to allow the charm to run on xenial
- Adding a bit more logging
- Fixing an issue with open() in 'r+' mode where truncate() wasn't being called which led to extra content at the end of the file

Reviewed-on: https://code.launchpad.net/~cmisare/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/402298
Reviewed-by: Haw Loeung <email address hidden>