charm-ubuntu-advantage

~jfguedez/charm-ubuntu-advantage:bug/1944591

  1. Git
  2. lp:~jfguedez/charm-ubuntu-advantage
  3. bug/1944591
Last commit made on 2022-02-24
Get this branch:
git clone -b bug/1944591 https://git.launchpad.net/~jfguedez/charm-ubuntu-advantage
Only Jose Guedez can upload to this branch. If you are Jose Guedez please log in for upload directions.

Branch merges

Branch information

Name:
bug/1944591
Repository:
lp:~jfguedez/charm-ubuntu-advantage

Recent commits

e8265de... by Jose Guedez

Refactor proxy support

* apt already supports proxy via apt-http[s]-proxy variables
* add proxy configuration to the UA client
* only `add-apt-repository` needs environment variables
* update unit tests, and add an extra test to cover proxies

e1f54bb... by Jose Guedez

fix broken unit tests

493ac61... by Bartosz Woronicz

Add support for proxy settings from the model

Closes-Bug: 1944591

a0f3abf... by Tom Haddon

Update readme to use charmhub location

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/411170
Reviewed-by: Colin Misare <email address hidden>

f423771... by Tom Haddon

Update readme to use charmhub location

5d93cdb... by Colin Misare

Bug fix and improved logging

- Pinning to ops==1.1.0 until until https://github.com/canonical/operator/pull/520 is published to allow the charm to run on xenial
- Adding a bit more logging
- Fixing an issue with open() in 'r+' mode where truncate() wasn't being called which led to extra content at the end of the file

Reviewed-on: https://code.launchpad.net/~cmisare/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/402298
Reviewed-by: Haw Loeung <email address hidden>

1a08cb2... by Colin Misare

bug fix and improved logging

5078ac0... by Colin Misare

Lots of fixes and refactoring:

- Fix command in README to use the correctly named 'token' configuration value
- Switch contract_url to be a juju default config value instead of code default value
- Cleaner file read/write behavior for uaclient.conf
- Fixed subscription flow to behave correctly with default values and changed config values
- Update tests to create mocks in setUp so every test will have default mocks instead of accidentally making real subprocess or open calls
- Cleaned up tests to only verify what that test cares about, and rely on other tests to correctly verify their own behavior
- Minor formatting updates around double and single quotes

Reviewed-on: https://code.launchpad.net/~cmisare/charm-ubuntu-advantage/+git/charm-ubuntu-advantage/+merge/400942
Reviewed-by: Tom Haddon <email address hidden>

df6a08b... by Colin Misare

few more small changes based on feedback

45397d3... by Colin Misare

large refactor