Merge lp:~jfb-tempo-consulting/unifield-web/us-1335 into lp:unifield-web

Proposed by jftempo
Status: Merged
Merged at revision: 4831
Proposed branch: lp:~jfb-tempo-consulting/unifield-web/us-1335
Merge into: lp:unifield-web
Diff against target: 74 lines (+12/-3)
2 files modified
addons/openerp/controllers/actions.py (+5/-0)
addons/openerp/static/javascript/openerp/openerp.base.js (+7/-3)
To merge this branch: bzr merge lp:~jfb-tempo-consulting/unifield-web/us-1335
Reviewer Review Type Date Requested Status
UniField Dev Team Pending
Review via email: mp+314720@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/controllers/actions.py'
2--- addons/openerp/controllers/actions.py 2016-11-25 09:20:18 +0000
3+++ addons/openerp/controllers/actions.py 2017-01-13 15:45:45 +0000
4@@ -424,6 +424,7 @@
5 action['target'] = 'popup'
6 open_new_tab = True
7
8+
9 # search_view key in action is >8k added to the URL every time, which
10 # breaks firefox (and probably Apache) as it's shoved into a header and
11 # then used back as a URL
12@@ -458,6 +459,8 @@
13
14 cherrypy.response.headers['X-Target'] = action['target']
15 cherrypy.response.headers['Location'] = url
16+ if action and action.get('keep_open'):
17+ cherrypy.response.headers['keep-open'] = 1
18 return """<script type="text/javascript">
19 window.top.openAction('%s', '%s');
20 </script>
21@@ -594,6 +597,8 @@
22
23 @tools.expose(template="/openerp/controllers/templates/report.mako")
24 def report_link(report_name, **kw):
25+ if kw.get('keep_open'):
26+ cherrypy.response.headers['keep-open'] = 1
27 cherrypy.response.headers['X-Target'] = 'download'
28 cherrypy.response.headers['Location'] = tools.url(
29 '/openerp/report', report_name=report_name, **kw)
30
31=== modified file 'addons/openerp/static/javascript/openerp/openerp.base.js'
32--- addons/openerp/static/javascript/openerp/openerp.base.js 2016-08-29 07:31:56 +0000
33+++ addons/openerp/static/javascript/openerp/openerp.base.js 2017-01-13 15:45:45 +0000
34@@ -122,9 +122,11 @@
35 return function (data, status, xhr) {
36 var target;
37 var active_id;
38+ var keep_open = false;
39 if(xhr.getResponseHeader){
40 target = xhr.getResponseHeader('X-Target');
41 active_id = xhr.getResponseHeader('active_id');
42+ keep_open = xhr.getResponseHeader('keep-open');
43 }
44 if(target) {
45 var _openAction;
46@@ -133,7 +135,7 @@
47 } else {
48 _openAction = openAction;
49 }
50- _openAction(xhr.getResponseHeader('Location'), target, active_id);
51+ _openAction(xhr.getResponseHeader('Location'), target, active_id, keep_open);
52 return;
53 }
54 if(url) {
55@@ -181,7 +183,7 @@
56 * @param action_url the URL of the action to open
57 * @param target the target, if any, defaults to 'current'
58 */
59-function openAction(action_url, target, terp_id) {
60+function openAction(action_url, target, terp_id, keep_open) {
61 var $dialogs = jQuery('.action-dialog');
62 switch(target) {
63 case 'new':
64@@ -228,7 +230,9 @@
65 default:
66 openLink(action_url);
67 }
68- $dialogs.dialog('close');
69+ if (!keep_open) {
70+ $dialogs.dialog('close');
71+ }
72 }
73 function closeAction() {
74 jQuery('.action-dialog').dialog('close');

Subscribers

People subscribed via source and target branches