Merge lp:~jfb-tempo-consulting/unifield-web/US-7530 into lp:unifield-web

Proposed by jftempo
Status: Merged
Merged at revision: 4999
Proposed branch: lp:~jfb-tempo-consulting/unifield-web/US-7530
Merge into: lp:unifield-web
Diff against target: 108 lines (+29/-24)
4 files modified
addons/openerp/controllers/templates/search.mako (+12/-9)
addons/openerp/widgets/form/_m2m.py (+4/-1)
addons/openerp/widgets/form/templates/many2many.mako (+1/-0)
addons/openerp/widgets/templates/listgrid/listgrid.mako (+12/-14)
To merge this branch: bzr merge lp:~jfb-tempo-consulting/unifield-web/US-7530
Reviewer Review Type Date Requested Status
UniField Dev Team Pending
Review via email: mp+393182@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/controllers/templates/search.mako'
2--- addons/openerp/controllers/templates/search.mako 2017-06-01 13:48:36 +0000
3+++ addons/openerp/controllers/templates/search.mako 2020-11-02 12:53:21 +0000
4@@ -66,18 +66,21 @@
5 }
6 </script>
7 % else:
8- <script type="text/javascript">
9+ <script type="text/javascript">
10 function close_dialog() {
11 jQuery.m2m('close');
12 }
13- function do_select(id) {
14- jQuery.m2m('close',
15- id ? [parseInt(id, 10)].concat(ListView('_terp_list').get_previously_selected())
16- : ListView('_terp_list').get_previously_selected()
17-
18- );
19- }
20- </script>
21+ function do_select(id) {
22+ var prev_selected = ListView('_terp_list').get_previously_selected();
23+ if (id) {
24+ var int_id = parseInt(id, 10);
25+ if (jQuery.inArray(int_id, prev_selected) == -1) {
26+ prev_selected.push(int_id);
27+ }
28+ }
29+ jQuery.m2m('close', prev_selected);
30+ }
31+ </script>
32 % endif
33 % endif
34 <script type="text/javascript">
35
36=== modified file 'addons/openerp/widgets/form/_m2m.py'
37--- addons/openerp/widgets/form/_m2m.py 2019-05-03 12:59:31 +0000
38+++ addons/openerp/widgets/form/_m2m.py 2020-11-02 12:53:21 +0000
39@@ -150,7 +150,10 @@
40 if self.editable is False:
41 selectable = 0
42 else:
43- selectable = 2
44+ if attrs.get("m2m_selectable"):
45+ selectable = 2
46+ else:
47+ selectable = 3
48
49 # try to get original input values if creating validation form
50 if not params.filter_action:
51
52=== modified file 'addons/openerp/widgets/form/templates/many2many.mako'
53--- addons/openerp/widgets/form/templates/many2many.mako 2010-08-31 07:05:04 +0000
54+++ addons/openerp/widgets/form/templates/many2many.mako 2020-11-02 12:53:21 +0000
55@@ -9,6 +9,7 @@
56 % else:
57 <input type="hidden" class="${css_class}" id='${name}_set' kind="${kind}" ${py.attrs(attrs)} style="width: 100%;"/>
58 % endif
59+ <input type="hidden" name="${name}/_terp_previously_selected" id="${name}/_terp_previously_selected" />
60 % if error:
61 <span class="fielderror">${error}</span>
62 % endif
63
64=== modified file 'addons/openerp/widgets/templates/listgrid/listgrid.mako'
65--- addons/openerp/widgets/templates/listgrid/listgrid.mako 2020-08-06 14:23:27 +0000
66+++ addons/openerp/widgets/templates/listgrid/listgrid.mako 2020-11-02 12:53:21 +0000
67@@ -95,18 +95,16 @@
68 % if selector:
69 <td class="grid-cell selector">
70 % if not data['id'] or data['id'] not in notselectable:
71- % if not m2m:
72- <%
73- nosidedar = name != '_terp_list' and 'true' or 'false'
74- selector_click = "new ListView('%s').onBooleanClicked(!this.checked, '%s', %s);" % (name, data['id'], nosidedar)
75- if selector == "radio":
76- selector_click += " do_select();"
77- %>
78- <input type="${selector}" class="${selector} grid-record-selector"
79- id="${name}/${data['id']}" name="${(checkbox_name or None) and name}"
80- value="${data['id']}"
81- onclick="${selector_click}"/>
82- % endif
83+ <%
84+ nosidedar = name != '_terp_list' and 'true' or 'false'
85+ selector_click = "new ListView('%s').onBooleanClicked(!this.checked, '%s', %s);" % (name, data['id'], nosidedar)
86+ if selector == "radio":
87+ selector_click += " do_select();"
88+ %>
89+ <input type="${selector}" class="${selector} grid-record-selector"
90+ id="${name}/${data['id']}" name="${(checkbox_name or None) and name}"
91+ value="${data['id']}"
92+ onclick="${selector_click}"/>
93 % endif
94 </td>
95 % endif
96@@ -340,10 +338,10 @@
97 <tr class="grid-header">
98 % if selector:
99 <th width="1" class="grid-cell selector">
100- % if selector == 'checkbox' and not m2m:
101+ % if selector == 'checkbox':
102 <input type="checkbox" class="checkbox grid-record-selector" id="${name}_check_all" onclick="new ListView('${name}').checkAll(!this.checked)"/>
103 % endif
104- % if selector != 'checkbox' and not m2m:
105+ % if selector != 'checkbox':
106 <span>&nbsp;</span>
107 % endif
108 </th>

Subscribers

People subscribed via source and target branches