Merge lp:~jfb-tempo-consulting/unifield-server/us-2146 into lp:unifield-server

Proposed by jftempo
Status: Merged
Merge reported by: jftempo
Merged at revision: not available
Proposed branch: lp:~jfb-tempo-consulting/unifield-server/us-2146
Merge into: lp:unifield-server
Diff against target: 93 lines (+20/-48)
1 file modified
bin/addons/board/queries_finance.py (+20/-48)
To merge this branch: bzr merge lp:~jfb-tempo-consulting/unifield-server/us-2146
Reviewer Review Type Date Requested Status
UniField Reviewer Team Pending
Review via email: mp+315340@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/addons/board/queries_finance.py'
2--- bin/addons/board/queries_finance.py 2016-11-10 15:58:28 +0000
3+++ bin/addons/board/queries_finance.py 2017-01-23 11:00:37 +0000
4@@ -51,34 +51,20 @@
5 account_move.name,
6 account_account.code,
7 avg(account_move_line.credit_currency-account_move_line.debit_currency) JI,
8-sum(account_analytic_line.amount_currency) AJI,
9-abs(abs(avg(account_move_line.debit_currency-account_move_line.credit_currency)) - abs(sum(account_analytic_line.amount_currency))) difference
10+sum(COALESCE(account_analytic_line.amount_currency, 0)) AJI,
11+abs(abs(avg(account_move_line.debit_currency-account_move_line.credit_currency)) - abs(sum(COALESCE(account_analytic_line.amount_currency, 0)))) difference
12 FROM
13-account_move,
14-account_move_line,
15-account_account,
16-account_analytic_line,
17-account_journal,
18-account_period
19+account_move_line
20+JOIN account_move ON account_move.id = account_move_line.move_id
21+JOIN account_account ON account_account.id = account_move_line.account_id
22+JOIN account_journal ON account_journal.id = account_move.journal_id
23+JOIN account_period ON account_move.period_id = account_period.id
24+LEFT JOIN account_analytic_line on account_analytic_line.move_id = account_move_line.id
25 WHERE
26-account_analytic_line.move_id = account_move_line.id and
27-account_move_line.move_id = account_move.id AND
28-account_move_line.account_id = account_account.id AND
29-account_journal.id = account_move.journal_id AND
30-account_move.period_id = account_period.id AND
31 account_journal.type not in ('system', 'revaluation', 'cur_adj') AND
32-account_account.code in (
33-SELECT
34-account_account.code
35-FROM
36-account_account,
37-account_account_type
38-WHERE
39-account_account.user_type = account_account_type.id and
40-account_account_type.code in ('income', 'expense')
41-)
42+account_account.is_analytic_addicted = 't'
43 GROUP BY account_period.name, account_move.name, account_move_line.id, account_period.date_start, account_account.code
44-HAVING abs(abs(avg(account_move_line.debit_currency-account_move_line.credit_currency)) - abs(sum(account_analytic_line.amount_currency))) > 0.00001
45+HAVING abs(abs(avg(account_move_line.debit_currency-account_move_line.credit_currency)) - abs(sum(COALESCE(account_analytic_line.amount_currency, 0)))) > 0.00001
46 ORDER BY account_period.date_start, account_move.name"""
47 },
48 {
49@@ -89,34 +75,20 @@
50 account_move.name,
51 account_account.code,
52 avg(account_move_line.credit-account_move_line.debit) JI,
53-sum(account_analytic_line.amount) AJI,
54-abs(avg(account_move_line.credit-account_move_line.debit) - sum(account_analytic_line.amount)) difference
55+sum(COALESCE(account_analytic_line.amount, 0)) AJI,
56+abs(avg(account_move_line.credit-account_move_line.debit) - sum(COALESCE(account_analytic_line.amount, 0))) difference
57 FROM
58-account_move,
59-account_move_line,
60-account_account,
61-account_analytic_line,
62-account_journal,
63-account_period
64+account_move_line
65+JOIN account_move ON account_move.id = account_move_line.move_id
66+JOIN account_account ON account_account.id = account_move_line.account_id
67+JOIN account_journal ON account_move.journal_id = account_journal.id
68+JOIN account_period ON account_period.id = account_move.period_id
69+LEFT JOIN account_analytic_line ON account_analytic_line.move_id = account_move_line.id
70 WHERE
71-account_analytic_line.move_id = account_move_line.id and
72-account_move_line.move_id = account_move.id AND
73-account_move_line.account_id = account_account.id AND
74-account_journal.id = account_move.journal_id AND
75-account_move.period_id = account_period.id AND
76 account_journal.type in ('revaluation', 'cur_adj') AND
77-account_account.code in (
78-SELECT
79-account_account.code
80-FROM
81-account_account,
82-account_account_type
83-WHERE
84-account_account.user_type = account_account_type.id and
85-account_account_type.code in ('income', 'expense')
86-)
87+account_account.is_analytic_addicted = 't'
88 GROUP BY account_period.name, account_move.name, account_move_line.id, account_period.date_start, account_account.code
89-HAVING abs(avg(account_move_line.credit-account_move_line.debit) - sum(account_analytic_line.amount)) > 0.00001
90+HAVING abs(avg(account_move_line.credit-account_move_line.debit) - sum(COALESCE(account_analytic_line.amount, 0))) > 0.00001
91 order by account_period.date_start, account_move.name"""
92 },
93 {

Subscribers

People subscribed via source and target branches