Merge lp:~jfb-tempo-consulting/unifield-server/us-1765 into lp:unifield-server

[jftempo]

=== modified file 'bin/addons/purchase_override/purchase.py'
--- bin/addons/purchase_override/purchase.py	2016-09-26 07:39:38 +0000
+++ bin/addons/purchase_override/purchase.py	2016-10-10 12:23:14 +0000
@@ -416,9 +416,12 @@
             string='Update in progress',
             readonly=True,
         ),
+        # US-1765: register the 1st call of wkf_confirm_trigger to prevent recursion error
+        'po_confirmed': fields.boolean('PO', readonly=True),
     }
 
     _defaults = {
+        'po_confirmed': lambda *a: False,
         'order_type': lambda *a: 'regular',
         'priority': lambda *a: 'normal',
         'categ': lambda *a: 'other',
@@ -1815,7 +1818,6 @@
             context = {}
         if isinstance(ids, (int, long)):
             ids = [ids]
-
         # objects
         so_obj = self.pool.get('sale.order')
         wf_service = netsvc.LocalService("workflow")
@@ -1829,14 +1831,29 @@
         # from all so, list all corresponding po second level
         all_po_for_all_so_ids = so_obj.get_po_ids_from_so_ids(cr, uid, all_so_ids, context=context)
 
+        # we trigger all the corresponding sale order -> test_lines is called on these so
+        for so_id in all_so_ids:
+            wf_service.trg_write(uid, 'sale.order', so_id, cr)
+
         not_confirmed_po = self.search(cr, uid, [
             ('id', 'not in', all_po_for_all_so_ids),
             ('state', '=', 'confirmed_wait'),
         ], context=context)
 
-        # we trigger all the corresponding sale order -> test_lines is called on these so
-        for so_id in all_so_ids:
-            wf_service.trg_write(uid, 'sale.order', so_id, cr)
+        # US-1765: PO linked to multiple POs, last PO confirmed
+        # wkf_confirm_trigger is called for this PO and after again and again and again for each linked POs (by the workflow)
+        # register the first call by setting po_confirmed=True and do not process the others
+        confirmed = False
+        if all_po_for_all_so_ids:
+            confirmed = self.search(cr, uid,
+                    [('id', 'in', all_po_for_all_so_ids), ('po_confirmed', '=', True)], context=context)
+        if confirmed:
+            # one of the linked PO has already triggered this method for all POs, so we can stop
+            return True
+        if ids:
+            # register the call
+            # direct sql to not trigger (again) the workflow
+            cr.execute('''update purchase_order set po_confirmed='t' where id in %s''', (tuple(ids),))
 
         # we trigger pos of all sale orders -> all_po_confirm is called on these po
         for po_id in all_po_for_all_so_ids: