Merge ~jessica-youjeong/ubuntu/+source/librabbitmq:031822-bionic-devel-librabbitmq into ubuntu/+source/librabbitmq:ubuntu/bionic-devel

Proposed by Jess Jang
Status: Work in progress
Proposed branch: ~jessica-youjeong/ubuntu/+source/librabbitmq:031822-bionic-devel-librabbitmq
Merge into: ubuntu/+source/librabbitmq:ubuntu/bionic-devel
Diff against target: 77 lines (+53/-1)
3 files modified
debian/changelog (+8/-1)
debian/patches/series (+3/-0)
debian/patches/server_flag_deprecation.patch (+42/-0)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Pending
Review via email: mp+417114@code.launchpad.net

Commit message

This MP contains a fix for LP: 1888313, which I intend to SRU as well, so this is a fix for Bionic which is backported from link below. The package was successfully built using sbuild and I also ran the autopkgtest and all the tests are passing.

Requesting you to please review and sponsor the upload. Thank you!

[https://code.launchpad.net/~jessica-youjeong/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/417036]

To post a comment you must log in.

Unmerged commits

4583101... by Jess Jang

changelog

cd486b7... by Jess Jang

  * d/p/server-flag-deprecation.patch:
    add patch to fix issue parsing hostname in --server flag.
    (LP: #1888313)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8d4f34b..af492df 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,5 +1,12 @@
6-librabbitmq (0.8.0-1ubuntu0.18.04.2) bionic-security; urgency=medium
7+librabbitmq (0.8.0-1ubuntu0.18.04.3) bionic; urgency=medium
8+
9+ * d/p/server-flag-deprecation.patch:
10+ add patch to fix issue parsing hostname in --server flag.
11+ (LP: #1888313)
12
13+ -- Jess Jang <jess.jang@canonical.com> Thu, 03 Feb 2022 14:30:36 -0600
14+
15+librabbitmq (0.8.0-1ubuntu0.18.04.2) bionic-security; urgency=medium
16 * SECURITY UPDATE: Integer overflow
17 - debian/patches/CVE-2019-18609.patch: check frame_size is >= INT32_MAX
18 in librabbitmq/amqp_connection.c.
19diff --git a/debian/patches/series b/debian/patches/series
20index ee127a2..180be81 100644
21--- a/debian/patches/series
22+++ b/debian/patches/series
23@@ -2,3 +2,6 @@ cmake_with_ssl.patch
24 use_cmake_package.patch
25 fix-parameter-processing.patch
26 CVE-2019-18609.patch
27+disable-test-basic.patch
28+ssl-remove-reference-to-FIPS_set_mode.patch
29+server_flag_deprecation.patch
30diff --git a/debian/patches/server_flag_deprecation.patch b/debian/patches/server_flag_deprecation.patch
31new file mode 100644
32index 0000000..de99b0b
33--- /dev/null
34+++ b/debian/patches/server_flag_deprecation.patch
35@@ -0,0 +1,42 @@
36+From 637f0275ffcc2bfb58c94f0bf6e290aa40c1695a Mon Sep 17 00:00:00 2001
37+From: Alan Antonuk <alan.antonuk@gmail.com>
38+Date: Fri, 7 Aug 2020 05:07:50 +0000
39+Subject: [PATCH] tool: set port when not specified in --server flag
40+
41+Set the port to 5672 and 5671 in SSL mode in the tools when the --server
42+flag is used, but does not specify a port.
43+
44+From 54d00bee5cc4603dc96af5f86c899210689dfeeb Mon Sep 17 00:00:00 2001
45+From: Alan Antonuk <alan.antonuk@gmail.com>
46+Date: Sun, 9 Aug 2020 06:44:28 +0000
47+Subject: [PATCH] tool: fix issue parsing hostname in --server flag
48+
49+Set both the host and port when a ':' isn't found in in the --server
50+flag. The attempted fix in #622 was not complete as the host was not
51+properly set.
52+
53+Fixes: #621
54+
55+Origin: upstream;
56+ https://github.com/alanxz/rabbitmq-c/commit/637f0275ffcc2bfb58c94f0bf6e290aa40c1695a
57+ https://github.com/alanxz/rabbitmq-c/commit/4d03c849868231dc217785c6f0e78eab9cd79fd5
58+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1888313
59+Last-Updated: 2022-01-19
60+
61+--- a/tools/common.c
62++++ b/tools/common.c
63+@@ -240,6 +240,14 @@
64+ if (ci->port < 0 || ci->port > 65535 || port_end == colon + 1 ||
65+ *port_end != 0)
66+ die("bad server port number in '%s'", amqp_server);
67++ } else {
68++ ci->host = amqp_server;
69++ ci->port = 5672;
70++#if WITH_SSL
71++ if (amqp_ssl) {
72++ ci->port = 5671;
73++ }
74++#endif
75+ }
76+
77+ #if WITH_SSL

Subscribers

People subscribed via source and target branches