Merge ~jessica-youjeong/ubuntu/+source/librabbitmq:031822-impish-devel-librabbitmq into ubuntu/+source/librabbitmq:ubuntu/impish-devel

Proposed by Jess Jang
Status: Work in progress
Proposed branch: ~jessica-youjeong/ubuntu/+source/librabbitmq:031822-impish-devel-librabbitmq
Merge into: ubuntu/+source/librabbitmq:ubuntu/impish-devel
Diff against target: 81 lines (+59/-0)
3 files modified
debian/changelog (+15/-0)
debian/patches/series (+2/-0)
debian/patches/server_flag_deprecation.patch (+42/-0)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Pending
Review via email: mp+417113@code.launchpad.net

Description of the change

This MP contains a fix for LP: 1888313, which I intend to SRU as well, so this is a fix for Impish which is backported from link below. The package was successfully built using sbuild and I also ran the autopkgtest and all the tests are passing.

Requesting you to please review and sponsor the upload. Thank you!

[https://code.launchpad.net/~jessica-youjeong/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/417036]

To post a comment you must log in.

Unmerged commits

dc6b0aa... by Jess Jang

changelog

c4e3ecd... by Jess Jang

  * d/p/server-flag-deprecation.patch:
    add patch to fix issue parsing hostname in --server flag.
    (LP: #1888313)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 19ba96d..7b5b69e 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,18 @@
6+librabbitmq (0.10.0-1ubuntu1.21.10.1) impish; urgency=medium
7+
8+ * d/p/server-flag-deprecation.patch:
9+ add patch to fix issue parsing hostname in --server flag.
10+ (LP: #1888313)
11+
12+ -- Jess Jang <jess.jang@canonical.com> Thu, 03 Feb 2022 14:30:36 -0600
13+
14+librabbitmq (0.10.0-1ubuntu1) jammy; urgency=medium
15+
16+ * d/p/ssl-remove-reference-to-FIPS_set_mode.patch: backported
17+ to fix the build against OpenSSL 3.0 (LP: #1945812)
18+
19+ -- Simon Chopin <simon.chopin@canonical.com> Wed, 17 Nov 2021 14:22:23 +0100
20+
21 librabbitmq (0.10.0-1build1) impish; urgency=medium
22
23 * No-change rebuild to build packages with zstd compression.
24diff --git a/debian/patches/series b/debian/patches/series
25index f96d27b..3365953 100644
26--- a/debian/patches/series
27+++ b/debian/patches/series
28@@ -1,3 +1,5 @@
29 cmake_with_ssl.patch
30 use_cmake_package.patch
31 disable-test-basic.patch
32+ssl-remove-reference-to-FIPS_set_mode.patch
33+server_flag_deprecation.patch
34diff --git a/debian/patches/server_flag_deprecation.patch b/debian/patches/server_flag_deprecation.patch
35new file mode 100644
36index 0000000..de99b0b
37--- /dev/null
38+++ b/debian/patches/server_flag_deprecation.patch
39@@ -0,0 +1,42 @@
40+From 637f0275ffcc2bfb58c94f0bf6e290aa40c1695a Mon Sep 17 00:00:00 2001
41+From: Alan Antonuk <alan.antonuk@gmail.com>
42+Date: Fri, 7 Aug 2020 05:07:50 +0000
43+Subject: [PATCH] tool: set port when not specified in --server flag
44+
45+Set the port to 5672 and 5671 in SSL mode in the tools when the --server
46+flag is used, but does not specify a port.
47+
48+From 54d00bee5cc4603dc96af5f86c899210689dfeeb Mon Sep 17 00:00:00 2001
49+From: Alan Antonuk <alan.antonuk@gmail.com>
50+Date: Sun, 9 Aug 2020 06:44:28 +0000
51+Subject: [PATCH] tool: fix issue parsing hostname in --server flag
52+
53+Set both the host and port when a ':' isn't found in in the --server
54+flag. The attempted fix in #622 was not complete as the host was not
55+properly set.
56+
57+Fixes: #621
58+
59+Origin: upstream;
60+ https://github.com/alanxz/rabbitmq-c/commit/637f0275ffcc2bfb58c94f0bf6e290aa40c1695a
61+ https://github.com/alanxz/rabbitmq-c/commit/4d03c849868231dc217785c6f0e78eab9cd79fd5
62+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1888313
63+Last-Updated: 2022-01-19
64+
65+--- a/tools/common.c
66++++ b/tools/common.c
67+@@ -240,6 +240,14 @@
68+ if (ci->port < 0 || ci->port > 65535 || port_end == colon + 1 ||
69+ *port_end != 0)
70+ die("bad server port number in '%s'", amqp_server);
71++ } else {
72++ ci->host = amqp_server;
73++ ci->port = 5672;
74++#if WITH_SSL
75++ if (amqp_ssl) {
76++ ci->port = 5671;
77++ }
78++#endif
79+ }
80+
81+ #if WITH_SSL

Subscribers

People subscribed via source and target branches