Merge ~jessica-youjeong/ubuntu/+source/librabbitmq:020322-jammy-devel-librabbitmq into ubuntu/+source/librabbitmq:ubuntu/devel

Proposed by Jess Jang
Status: Needs review
Proposed branch: ~jessica-youjeong/ubuntu/+source/librabbitmq:020322-jammy-devel-librabbitmq
Merge into: ubuntu/+source/librabbitmq:ubuntu/devel
Diff against target: 73 lines (+51/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/series (+1/-0)
debian/patches/server_flag_deprecation.patch (+42/-0)
Reviewer Review Type Date Requested Status
Utkarsh Gupta (community) Approve
Review via email: mp+417036@code.launchpad.net

Description of the change

This MP contains a fix for LP: 1888313, which I intend to SRU as well, so this is a fix for Jammy first. The package was successfully built using sbuild and I also ran the autopkgtest and all the tests are passing.

Requesting you to please review and sponsor the upload. Thank you!

To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hello,

This looks good. Thank you very much! Sponsored the upload:

$ dput ubuntu ../librabbitmq_0.10.0-1ubuntu2_source.changes
Checking signature on .changes
gpg: ../librabbitmq_0.10.0-1ubuntu2_source.changes: Valid signature from 823E967606C34B96
Checking signature on .dsc
gpg: ../librabbitmq_0.10.0-1ubuntu2.dsc: Valid signature from 823E967606C34B96
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading librabbitmq_0.10.0-1ubuntu2.dsc: done.
  Uploading librabbitmq_0.10.0.orig.tar.gz: done.
  Uploading librabbitmq_0.10.0-1ubuntu2.debian.tar.xz: done.
  Uploading librabbitmq_0.10.0-1ubuntu2_source.buildinfo: done.
  Uploading librabbitmq_0.10.0-1ubuntu2_source.changes: done.
Successfully uploaded packages.

review: Approve

Unmerged commits

587da76... by Jess Jang

changelog

ddfc942... by Jess Jang

  * d/p/server-flag-deprecation.patch:
    add patch to fix issue parsing hostname in --server flag.
    (LP: #1888313)

54e739a... by Simon Chopin

0.10.0-1ubuntu1 (patches unapplied)

Imported using git-ubuntu import.

1a940e6... by Matthias Klose

0.10.0-1build1 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8c9e075..34b90f7 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+librabbitmq (0.10.0-1ubuntu2) jammy; urgency=medium
7+
8+ * d/p/server-flag-deprecation.patch:
9+ add patch to fix issue parsing hostname in --server flag.
10+ (LP: #1888313)
11+
12+ -- Jess Jang <jess.jang@canonical.com> Thu, 03 Feb 2022 14:30:36 -0600
13+
14 librabbitmq (0.10.0-1ubuntu1) jammy; urgency=medium
15
16 * d/p/ssl-remove-reference-to-FIPS_set_mode.patch: backported
17diff --git a/debian/patches/series b/debian/patches/series
18index 7d40e1f..3365953 100644
19--- a/debian/patches/series
20+++ b/debian/patches/series
21@@ -2,3 +2,4 @@ cmake_with_ssl.patch
22 use_cmake_package.patch
23 disable-test-basic.patch
24 ssl-remove-reference-to-FIPS_set_mode.patch
25+server_flag_deprecation.patch
26diff --git a/debian/patches/server_flag_deprecation.patch b/debian/patches/server_flag_deprecation.patch
27new file mode 100644
28index 0000000..de99b0b
29--- /dev/null
30+++ b/debian/patches/server_flag_deprecation.patch
31@@ -0,0 +1,42 @@
32+From 637f0275ffcc2bfb58c94f0bf6e290aa40c1695a Mon Sep 17 00:00:00 2001
33+From: Alan Antonuk <alan.antonuk@gmail.com>
34+Date: Fri, 7 Aug 2020 05:07:50 +0000
35+Subject: [PATCH] tool: set port when not specified in --server flag
36+
37+Set the port to 5672 and 5671 in SSL mode in the tools when the --server
38+flag is used, but does not specify a port.
39+
40+From 54d00bee5cc4603dc96af5f86c899210689dfeeb Mon Sep 17 00:00:00 2001
41+From: Alan Antonuk <alan.antonuk@gmail.com>
42+Date: Sun, 9 Aug 2020 06:44:28 +0000
43+Subject: [PATCH] tool: fix issue parsing hostname in --server flag
44+
45+Set both the host and port when a ':' isn't found in in the --server
46+flag. The attempted fix in #622 was not complete as the host was not
47+properly set.
48+
49+Fixes: #621
50+
51+Origin: upstream;
52+ https://github.com/alanxz/rabbitmq-c/commit/637f0275ffcc2bfb58c94f0bf6e290aa40c1695a
53+ https://github.com/alanxz/rabbitmq-c/commit/4d03c849868231dc217785c6f0e78eab9cd79fd5
54+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1888313
55+Last-Updated: 2022-01-19
56+
57+--- a/tools/common.c
58++++ b/tools/common.c
59+@@ -240,6 +240,14 @@
60+ if (ci->port < 0 || ci->port > 65535 || port_end == colon + 1 ||
61+ *port_end != 0)
62+ die("bad server port number in '%s'", amqp_server);
63++ } else {
64++ ci->host = amqp_server;
65++ ci->port = 5672;
66++#if WITH_SSL
67++ if (amqp_ssl) {
68++ ci->port = 5671;
69++ }
70++#endif
71+ }
72+
73+ #if WITH_SSL

Subscribers

People subscribed via source and target branches